Re: [whatwg/fetch] processResponseDone should receive a response (#1202)

@annevk commented on this pull request.

I think this is problematic as this would distinguish a CORS network error from other network errors. That they are indistinguishable is a desirable security property.

Can we still remove this from implementations?

I checked other network errors, such as a bad port, and we don't seem to be creating RT entries there, but I haven't done exhaustive testing for all possible network errors.

I'm also a bit concerned that somewhere we might do if "response is a network error, return a network error" which would drop this kind of information. I don't think we've audited that as there hasn't been a reason for it thus far.

cc @yoavweiss @npm1 @rniwa @bdekoz @sefeng211

> @@ -4019,7 +4027,7 @@ steps:
 
  <li><p>Set <var>response</var>'s <a for="response">timing info</a> to <var>timingInfo</var>.
 
- <li><p><a href="https://github.com/w3c/resource-timing/pull/261">Mark resource timing</a> for
+ <li><p><span>Mark resource timing</span> for

You want to use `<a>` here.

>  
+     <li><p>Set <var>response</var>'s <a for=response>timing info</a> to a new
+     <a for=/>fetch timing info</a> with its <a for="fetch timing info">start time</a> and its
+     <a for="fetch timing info">post-redirect start time</a> set to <var>fetchParams</var>'s
+     <a for="fetch params">timing info</a>'s <a for="fetch timing info">start time</a>, and
+     its <a for="fetch timing info">end time</a> set to the <a for=/>coarsened shared current

No newlines inside `<a>` et al.

> @@ -4251,9 +4259,20 @@ these steps:
 
    <li>
     <p>If <var>request</var>'s <a for=request>response tainting</a> is "<code>cors</code>" and a
-    <a>CORS check</a> for <var>request</var> and <var>response</var> returns failure, then return a
-    <a>network error</a>.
+    <a>CORS check</a> for <var>request</var> and <var>response</var> returns failure, then:
+    <ul>

This should be an ordered list.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1202#pullrequestreview-634571341