Re: [w3c/ServiceWorker] Fixing max scope to include trailing slash. (#1424)

mattto approved this pull request.

lgtm!

>            1. Else:
-              1. Let |maxScope| be the result of <a lt="URL parser">parsing</a> |serviceWorkerAllowed| with |job|'s [=job/script url=].
+              1. Let |maxScope| be the result of [=URL parser|parsing=] |serviceWorkerAllowed| with a [=base URL=] of |job|'s [=job/script url=].

optional nit: "job's script url's base URL" reads nicer to me. If it's "a base URL" it feels like there's multiple possible base URLs.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1424#pullrequestreview-246953199