Re: [w3c/ServiceWorker] Fixing max scope to include trailing slash. (#1424)

jakearchibald commented on this pull request.



>            1. Else:
-              1. Let |maxScope| be the result of <a lt="URL parser">parsing</a> |serviceWorkerAllowed| with |job|'s [=job/script url=].
+              1. Let |maxScope| be the result of [=URL parser|parsing=] |serviceWorkerAllowed| with a [=base URL=] of |job|'s [=job/script url=].

In this case "a base URL" refers to the argument of "URL parser" https://url.spec.whatwg.org/#concept-url-parser.

I could omit it, so it's "Let |maxScope| be the result of [=URL parser|parsing=] |serviceWorkerAllowed| with |job|'s [=job/script url=]."

Or I could be more specific, like "Let |maxScope| be the result of [=URL parser|parsing=] |serviceWorkerAllowed| using |job|'s [=job/script url=] as the [=base URL=]."

Any preference?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1424#discussion_r291487740