Re: [whatwg/fullscreen] Add FullscreenOptions dictionary to requestFullscreen (#129)

foolip approved this pull request.

Some of the phrasing in this PR is now my own after I tweaked the domintro and baked the "normative" (not really in this case) bits part of the algorithm.

This now looks good to me. Basic test at https://github.com/web-platform-tests/wpt/pull/12828. Further review is appreciated, and if there are no further requests for change I'll merge this sometime this week.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/129#pullrequestreview-152105923

Received on Tuesday, 4 September 2018 14:53:14 UTC