Re: [whatwg/fullscreen] Add FullscreenOptions dictionary to requestFullscreen (#129)

foolip commented on this pull request.



> @@ -155,8 +155,18 @@ steps:
 <h2 id=api>API</h2>
 
 <pre class=idl>
+enum <dfn>FullscreenNavigationUI</dfn> {
+  "auto",
+  "show",
+  "hide"
+};
+
+dictionary <dfn>FullscreenOptions</dfn> {
+  FullscreenNavigationUI navigationUI = "auto";
+};

I believe there's quite a mix on that front. I checked 5 cases at "random" before getting bored. Dictionaries first:
* https://drafts.csswg.org/cssom-view/#extensions-to-the-window-interface
* https://encoding.spec.whatwg.org/#interface-textdecoder
Dictionaries last:
* https://dom.spec.whatwg.org/#interface-eventtarget
* https://wicg.github.io/background-fetch/#background-fetch-manager
* https://w3c.github.io/sensors/#the-sensor-interface

I'll go with Dave's suggested order here since it reads fine to me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/129#discussion_r214896045