Re: [whatwg/fullscreen] Add FullscreenOptions dictionary to requestFullscreen (#129)

annevk commented on this pull request.



> @@ -254,11 +271,17 @@ these steps:
 
  <li><p>Return <var>promise</var>, and run the remaining steps <a>in parallel</a>.
 
- <li><p>If <var>error</var> is false: Resize <var>pendingDoc</var>'s
- <a>top-level browsing context</a>'s <a>active document</a>'s viewport's dimensions to match the
- dimensions of the screen of the output device. Optionally display a message how the end user can
- revert this.
- <!-- cross-process -->
+ <li>
+  <p>If <var>error</var> is false: Resize <var>pendingDoc</var>'s
+  <a>top-level browsing context</a>'s <a>active document</a>'s viewport's dimensions to match the
+  dimensions of the available screen of the output device, optionally taking into account
+  <var>options</var>'s <code>navigationUI</code> member. Optionally display a message how the end

You should describe here what the user agent might use the values for. Currently you'd have to infer it from all kinds of non-normative text you could ordinarily ignore.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/129#pullrequestreview-152354252

Received on Wednesday, 5 September 2018 06:48:25 UTC