Re: [whatwg/fullscreen] Remove nodes from top layer as part of the removing steps (#102)

upsuper requested changes on this pull request.



>  
  <li><p>Let <var>exitDocs</var> be the result of
  <a lt="collect documents to unfullscreen">collecting documents to unfullscreen</a> given
- <var>doc</var>.
+ <var>pendingDoc</var>.

IIUC, this will assert inside `collect documents to unfullscreen` because it expects `pendingDoc`'s fullscreen element to be not null, but it may be null when you are removing the fullscreen element from a simple fullscreen document. You probably want to also change that function to not assert in that case...

This also raises a problem that you may be going to add a `(pendingDoc, null)` into the `list of pending fullscreen events` in the following loop. And if the original document is not a simple fullscreen document, you are going to unfullscreen one further level.

One way to solve all these might be to change `collect documents to unfullscreen` to `collect documents and elements to unfullscreen` and build an array of `(document, element)`, and then you can pass `(pendingDoc, pending)` into the function, and remove the assertion. With that change, you don't need the separate insertion above.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/102#pullrequestreview-93144205