Re: [whatwg/fullscreen] Remove nodes from top layer as part of the removing steps (#102)

foolip commented on this pull request.



>  
- <li><p>If <var>doc</var>'s <a>fullscreen element</a> is null, then resolve <var>promise</var> with
- undefined and terminate these steps.
+ <li>
+  <p>If <var>pendingDoc</var>'s <a>fullscreen element</a> is not <var>pending</var>:

That's from https://github.com/whatwg/fullscreen/pull/92. The list is needed in case multiple things happen between two animation frames, in situation like https://github.com/whatwg/fullscreen/issues/63 or if we're in nested fullscreen and call `document.exitFullscreen()` twice. We *could* collapse those into a single `fullscreenchange` event, but that seems a bit odd. We could handle `fullscreenerror` differently, you're right, but that's not really part of the problem as long as the rest remain.

So I think that to do this differently, https://github.com/whatwg/fullscreen/issues/63 and https://github.com/whatwg/fullscreen/issues/119 would have to be resolved in the direction of significant simplification.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/102#discussion_r165257946