Re: [whatwg/fullscreen] Remove nodes from top layer as part of the removing steps (#102)

foolip commented on this pull request.



>  
  <li><p>Let <var>exitDocs</var> be the result of
  <a lt="collect documents to unfullscreen">collecting documents to unfullscreen</a> given
- <var>doc</var>.
+ <var>pendingDoc</var>.

OK, so this is a case where A will have `#outer` and `iframe` in top layer with the "fullscreen flag" set, but `iframe` doesn't have the the "iframe fullscreen flag" set. And B has just its `document.body` in top layer as the fullscreen element. Calling `document.exitFullscreen()` in B would normally leave us with with A having just `#outer` as the fullscreen element, i.e. we popped the `iframe` from top layer. But, with what I've proposed, we'd "terminate these steps" and document A would be left with two elements in top layer.

One possible stance is "oh well, removing the fullscreen element does weird things, just like exiting fullscreen twice can". But I'll take a look at your suggestions to tweak "collect documents to unfullscreen", to see if I can make that behave exactly as if the fullscreen element hadn't changed yet, kind of like how it was when the fullscreen element stack was separate.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/102#discussion_r165294522