Re: [whatwg/fullscreen] Remove nodes from top layer as part of the removing steps (#102)

upsuper commented on this pull request.



>  
- <li><p>If <var>doc</var>'s <a>fullscreen element</a> is null, then resolve <var>promise</var> with
- undefined and terminate these steps.
+ <li>
+  <p>If <var>pendingDoc</var>'s <a>fullscreen element</a> is not <var>pending</var>:

Another way around is to change `list of pending fullscreen events` to just `pending fullscreen event`, which is either null or `(string, element)` pair, and update, rather than append when new event comes.

I may be missing something, but I don't recall why we introduce the list rather than a single slot. Maybe we want to handle `fullscreenerror`? I guess `fullscreenerror` can just be dispatched asynchronously. I see no reason it is necessary to be dispatched in `run fullscreen steps`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/102#discussion_r165253519