- From: Adam Rice <notifications@github.com>
- Date: Thu, 07 Sep 2017 05:55:56 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 7 September 2017 12:56:23 UTC
The [[writableDone]] slot was only used to avoid calling WritableStreamDefaultControllerError when the stream wasn't writable. This is exactly the semantics that WritableStreamDefaultControllerErrorIfNeeded has, so use that instead. If abort() is called on the writable then cancel() is called on the readable(), the reason passed to abort() should be the one that errors the writable. Add tests to verify this behaviour. Fix a bug where a call to the underlying sink abort() method after the TransformStream was errored would cause an assert. You can view, comment on, or merge this pull request online at: https://github.com/whatwg/streams/pull/789 -- Commit Summary -- * Remove TransformStream's writableDone member -- File Changes -- M reference-implementation/lib/transform-stream.js (15) M reference-implementation/lib/writable-stream.js (2) M reference-implementation/to-upstream-wpts/transform-streams/errors.js (37) -- Patch Links -- https://github.com/whatwg/streams/pull/789.patch https://github.com/whatwg/streams/pull/789.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/789
Received on Thursday, 7 September 2017 12:56:23 UTC