Re: [whatwg/streams] Remove TransformStream's writableDone member (#789)

domenic approved this pull request.

So I guess what happened is that the reference implementation was written using only public APIs, and now we're fixing that---thus all the recent "remove extra state member" PRs. Nice to clean this up.

LGTM just some suggestions on a clearer commit message. Feel free to incorporate as many as you see fit and then merge at will.

I think the headline should be different, since there is a normative fix here as well. Maybe "Various fixes to transform.writable.abort() behavior"?

> Fix a bug where a call to the underlying sink abort() method after the TransformStream was errored would cause an assert.

I think phrasing this in terms of the public API behavior that triggers it (which is transform.writable.abort(), right?) would be clearer.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/789#pullrequestreview-61325220