Re: [whatwg/fetch] Adjust wildcard handling slightly (#592)

yutakahirano approved this pull request.

LGTM, all suggestions are optional.

> @@ -3916,21 +3912,40 @@ steps:
     happened due to <var>request</var>'s <a>use-CORS-preflight flag</a> being set is
     <a lt="CORS-preflight cache">cached</a>.
 
-   <li><p>If <var>request</var>'s <a for=request>method</a> is not in
-   <var>methods</var>, is not a <a>CORS-safelisted method</a>, and <var>methods</var> does
-   <em>not</em> contain `<code>*</code>`, then return a
-   <a>network error</a>.
+   <li>
+    <p>If all of the following are true
+
+    <ul class=brief>
+     <li><var>request</var>'s <a for=request>method</a> is not in <var>methods</var>
+
+     <li><var>request</var>'s <a for=request>method</a> is not a <a>CORS-safelisted method</a>
+
+     <li><var>request</var>'s <a for=request>credentials mode</a> is not "<code>include</code>"

The list is "and"-concatenated, so I think splitting this item into two is better.

> -   <li><p>If one of <var>request</var>'s <a for=request>header list</a>'
-   <a lt=name for=header>names</a> is not a <a>byte-case-insensitive</a> match for an
-   <a for=list>item</a> in <var>headerNames</var>, its corresponding <a for=/>header</a> is not a
-   <a>CORS-safelisted request-header</a>, and <var>headerNames</var> does not contain
-   `<code>*</code>`, then return a <a>network error</a>.
+   <li>
+    <p>If all of the following are true
+
+    <ul class=brief>
+     <li>one of <var>request</var>'s <a for=request>header list</a>'s <a for=header>names</a> is not
+     a <a>byte-case-insensitive</a> match for an <a for=list>item</a> in <var>headerNames</var>
+
+     <li>one of <var>request</var>'s <a for=request>header list</a>'s <a for=/>headers</a> is not a
+     <a>CORS-safelisted request-header</a>
+
+     <li><var>request</var>'s <a for=request>credentials mode</a> is not "<code>include</code>" and

ditto

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/592#pullrequestreview-60027385