Re: [whatwg/fetch] Adjust wildcard handling slightly (#592)

yutakahirano requested changes on this pull request.



>  
    <li><p>If one of <var>request</var>'s <a for=request>header list</a>'s
    <a lt=name for=header>names</a> is a <a>CORS non-wildcard request-header name</a> and is not a
    <a>byte-case-insensitive</a> match for an <a for=list>item</a> in <var>headerNames</var>, then
    return a <a>network error</a>.
 
    <li>
-    <p>If all of the following are true
+    <p>If one of <var>request</var>'s <a for=request>header list</a>'s <a for=header>names</a> is

Isn't this confusing? Imagine _request_ has two headers, "Accept" and "foobar", and "foobar" is listed in _headerNames_. But this branch is taken wrongly because

 - "Accept" is not a byte-case-insensitive match for an item in _headerNames_, and
 - "foobar" is not a CORS-safelisted request header. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/592#pullrequestreview-60132518