Re: [whatwg/fetch] Adjust wildcard handling slightly (#592)

annevk commented on this pull request.



> @@ -3916,21 +3912,40 @@ steps:
     happened due to <var>request</var>'s <a>use-CORS-preflight flag</a> being set is
     <a lt="CORS-preflight cache">cached</a>.
 
-   <li><p>If <var>request</var>'s <a for=request>method</a> is not in
-   <var>methods</var>, is not a <a>CORS-safelisted method</a>, and <var>methods</var> does
-   <em>not</em> contain `<code>*</code>`, then return a
-   <a>network error</a>.
+   <li>
+    <p>If all of the following are true
+
+    <ul class=brief>
+     <li><var>request</var>'s <a for=request>method</a> is not in <var>methods</var>
+
+     <li><var>request</var>'s <a for=request>method</a> is not a <a>CORS-safelisted method</a>
+
+     <li><var>request</var>'s <a for=request>credentials mode</a> is not "<code>include</code>"

I now think this is wrong. What if credentials mode is "include" and _methods_ does not contain request's method?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/592#discussion_r136512461