- From: Dominique Hazael-Massieux <notifications@github.com>
- Date: Sat, 22 Oct 2016 19:42:53 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/398@github.com>
A first stab at converting fullscreen to bikeshed. Verifications I have made after the conversion: * all the links to external specs from the current fetch appear in the same order in the new one (which has more of those due to autolinking done in bikeshed from WebIDL) * a visual inspection of the HTMLDiff (ignoring the transformation of "'s" to "’s") The conversion doesn't preserve all the ids yet; I'm not sure how critical that is. Bikeshed complains about the invalid IDL in the definition of `HeadersInit` and thus doesn't apply some of its magic to the fragment; not sure how that should be handled. It also tries to interpret the `'self'` in content policy as a CSS property description (and naturally fails to do so); I haven't figured out how to get rid of that spurious error yet. It also warns about missing ids on examples and headings, as well as non-reused `<var>` - I don't think any of those are particular important to fix in the short term at least. The bikeshed markup can probably be simplified some more; I've focused on fixing the results of the automatic conversion, not optimizing it for author convenience which can hopefully be done at a later stage. I cherry-picked and hand-coded the 2 commits that were merged after I got started, so this might need more git magic before merging, but I thought I would bring this is now to avoid further divergence. You can view, comment on, or merge this pull request online at: https://github.com/whatwg/fetch/pull/398 -- Commit Summary -- * Convert to bikeshed using convert-to-bikeshed.html * Set alias for references * Add line return after <pre> for bikeshed's sake * Add metadata * Escape internal slots syntax to avoid bikeshed confusing * Fix references * Fix quirks of automated conversion * Re-add interal links to interface objects and Origin header * Use backwards-compatible ids where possible * Allow fetch() to outlive document/workers * Editorial: note for `invalid` argument delete() -- File Changes -- M Overview.html (71) D Overview.src.html (5649) A fetch.bs (5775) -- Patch Links -- https://github.com/whatwg/fetch/pull/398.patch https://github.com/whatwg/fetch/pull/398.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/398
Received on Sunday, 23 October 2016 02:43:21 UTC