Re: [streams] Move stuff into controller to make RS and RBS closer (#418)

> constructor(controlledReadableStream, underlyingByteSource, size, highWaterMark) {
> Size seems unused. I don't think the signatures need to match, so we can probably remove it.

Done

> if (Number.isNaN(highWaterMark)) {
> maybe pull out a ValidateAndNormalizeHighWaterMark to share beween ValidateAndNormalizeQueuingStrategy and here.

Done

> ReadableStream API exposed for controllers.
> These should probably generally get asserts along the lines of IsReadableStreamReader(stream@[[reader]]) and IsReadableStreamBYOBReader(stream@[[reader]]) to make it clear which apply to which.

Done

> // A client of ReadableStreamController may use this function directly to bypass state check.
> The state checks should probably be added as asserts in all cases possible.

Done

---
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/418#issuecomment-171950318

Received on Friday, 15 January 2016 12:39:45 UTC