Re: [streams] Move stuff into controller to make RS and RBS closer (#418)

> this._cancel = CancelReadableStreamController;
> this._pull = PullFromReadableStreamController;
> Are you planning to move to the internal methods idea discussed in #418 (comment) ? I think in the reference implementation I would inline the method definitions in the class (_cancel() { ... }). In the spec they would be defined under the class as well.

Sorry! I forgot that. Inlined.

> I wonder if we should use methods for everything instead of just the polymorphic operations? Hmm let's stick with just the polymorphic ones for now. But maybe it will make things clearer eventually now that we have this more complex setup. I can do it in an editorial follow-up if we decide to go that route.

Yeah. Putting the abstract operations into classes just makes the code readable. But except for that point I don't have strong opinion now.

> FillPullIntoDescriptorFromQueue
> This reminded me that we should consider how we're going to divide these when speccing them, and try to arrange them correspondingly.

The list you wrote looks good. I just removed ReleaseReadableStreamReaderGenericForController. It's no longer necessary as automatic release feature is gone. I've moved the position of ReleaseReadableStreamReaderGeneric and renamed it by dropping Generic.

> TransferArrayBuffer
> should move to helpers.js

Done

---
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/418#issuecomment-171954344