Re: [web-bluetooth] Use AbortController for watchAdvertisements() (#480)

Sent from Yahoo Mail on Android 
 
  On Tue, Mar 17, 2020 at 10:00 AM, Ovidio Ruiz-Henríquez<notifications@github.com> wrote:   


@odejesush commented on this pull request.

In index.bs:
>  method, when invoked, MUST return <a>a new promise</a> |promise| and run the
 following steps:
 
 1. [=parallel queue/Enqueue the following steps=] to the [=watch advertisements
-    manager=], but [=abort when=] <code>this.{{unwatchAdvertisements()}}</code>
-    is called:
+    manager=]:
+    1. If |signal| how i can stop all thid[=AbortSignal/aborted flag=] is set, then:
+        1. [=Abort watchAdvertisements=] with |promise| and abort these steps.

I think that it would be the right thing to do. Otherwise, I don't see a way to cancel the operation if watchAdvertisements() is called without an AbortSignal. (Unless we make AbortSignal a required parameter).


—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.  


-- 
GitHub Notification of comment by lopezbeto
Please view or discuss this issue at https://github.com/WebBluetoothCG/web-bluetooth/pull/480#issuecomment-600188320 using your GitHub account

Received on Tuesday, 17 March 2020 17:05:52 UTC