Re: [web-bluetooth] Use AbortController for watchAdvertisements() (#480)

Sent from Yahoo Mail on Android 
 
  On Tue, Mar 17, 2020 at 12:48 PM, Reilly Grant<notifications@github.com> wrote:   


@reillyeon commented on this pull request.

In index.bs:
> @@ -2088,13 +2092,22 @@ A user agent has an associated <dfn>watch advertisements manager</dfn> which is
 the result of [=starting a new parallel queue=].
 
 <div algorithm="watchAdvertisements" class="unstable">
-The <code><dfn method for="BluetoothDevice">watchAdvertisements()</dfn></code>
-method, when invoked, MUST return <a>a new promise</a> |promise| and run the
-following steps:please  stop on this
-
+The <code><dfn method for="BluetoothDevice">watchAdvertisements(|options|)</dfn>
+</code> method, when invoked, MUST return <a>a new promise</a> |promise| and
+run the following steps:
+
+1. If <code>|options|.{{AbortSignal|signal}}</code> is present, then perform
+    the following sub-steps:
+    1. If <code>|options|.{{AbortSignal|signal}}</code>'s [=AbortSignal/aborted
+        flag=] is set, then [=abort watchAdvertisements=] with `this` and
+        |promise| and abort these steps.

Comma before the "and".

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub, or unsubscribe.  


-- 
GitHub Notification of comment by lopezbeto
Please view or discuss this issue at https://github.com/WebBluetoothCG/web-bluetooth/pull/480#issuecomment-600266214 using your GitHub account

Received on Tuesday, 17 March 2020 19:52:40 UTC