- From: Ovidio Ruiz-Henríquez via GitHub <sysbot+gh@w3.org>
- Date: Thu, 19 Mar 2020 22:33:07 +0000
- To: public-web-bluetooth-log@w3.org
> Sorry this review got so sprawling. I think this is basically right now. No worries, thanks a lot for helping me clean up and improve these algorithms significantly. In `watchAdvertisements()`, I moved the parallel queue step inside of the 'not-watching' state steps and after the state is set to 'pending-watch' because it made the abort condition make more sense. For example, if state was already `not-watching` then the abort condition is already met so it seemed a bit ambiguous as to what to do in that case. Let me know what you think of this change. -- GitHub Notification of comment by odejesush Please view or discuss this issue at https://github.com/WebBluetoothCG/web-bluetooth/pull/480#issuecomment-601447845 using your GitHub account
Received on Thursday, 19 March 2020 22:33:09 UTC