W3C home > Mailing lists > Public > public-test-infra@w3.org > April to June 2013

Re: Re: Checkout of web-platform-tests pull request

From: James Graham <jgraham@opera.com>
Date: Sun, 14 Apr 2013 18:49:38 +0200
To: "Dominique Hazael-Massieux" <dom@w3.org>
Cc: public-test-infra@w3.org
Message-ID: <4539b87833f6a55915ca329fce101881@opera.com>
-----Original Message----- 
> From: "Dominique Hazael-Massieux" <dom@w3.org> 
> To: "James Graham" <jgraham@opera.com> 
> Cc: public-test-infra@w3.org 
> Date: 2013-04-11 17:00 
> Subject: Re: Checkout of web-platform-tests pull request 
> > I can try adding these features to the code I wrote if there's any 
> > chance it will be used. If you are planning to start from scratch I 
> > won't bother :)
> I'd be very grateful if you could add these features to your code! Yes,
> I certainly intend to use it!

Well I added some features, but not quite the ones we discussed :) In particular rather than looking at labels I added the ability to mirror or unmirror particular pull requests by adding specially formatted comments to the issue associated with the PR (in particular a comment starting w3c-test:mirror or w3c-test:unmirror, respectively). This avoids the need for polling, so it was much easier to implement. In addition I restricted auto-mirroring, and the ability to run the aforementioned commands, to people that already have write access to the repo.

I have also moved the script onto github-proper, just so that it's a bit easier to work with [1]

I should note that *none* of the code that happens in response to github hooks has been tested at all. Therefore it *is* broken. But hopefully only in trivial ways rather than "this design is unworkable" ways.

[1] https://github.com/jgraham/github_sync
Received on Sunday, 14 April 2013 16:50:10 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 17:34:08 UTC