W3C home > Mailing lists > Public > public-svg-wg@w3.org > July to September 2008

SVGT12 testsuite review

From: Erik Dahlström <ed@opera.com>
Date: Tue, 23 Sep 2008 16:01:15 +0200
To: "public-svg-wg@w3.org" <public-svg-wg@w3.org>
Message-ID: <op.uhxs8d0lgqiacl@gnorps.linkoping.osa>

Hello svg-wg,

here are my comments on the 1.2T testsuite release:

Questions about test correctness:

  text-area-206-t.svg
    - Looks like the font-size on the text-area is 18 but it should be a smaller size in order for the text to be placed correctly on the blue lines.

  struct-svg-204-t.svg
    - When the test is included in a frame (<object> element) the width and height will be overridden by the user agent, at least for Opera 9.5 and FF3.

  linking-refs-203-t.svg
    - The alphabet a-j is too wide to fit in the textArea, and since we don't mandate forced word-breaking I suggest that it's split in two words.
    - The bottom-rightmost subtest assumes that the <use> does render even when it was a circular reference, is that mandated? That is: is it valid to not render the <use> at all (and thus not show the use:d rect)? I think the pass criteria needs to be a bit more loose on that subtest, like the other circular reference tests.

  interact-event-201-t.svg
    - The listener elements are listening to the wrong events. They should be listening for "DOMFocusIn" and "DOMFocusOut".

  udom-glob-201-t
    - Should be removed, there's no GlobalException interface anymore.



Invalid reference image:

  udom-svg-206-t
    - Should show 90% of regular size, and care should be taken that the reference isn't stretched by the UA (e.g by making a patch image that has some whitespace).

  shapes-rect-01-t.svg (compare reference with 1.1):
    http://www.w3.org/Graphics/SVG/Test/20080912/htmlObjectHarness/shapes-rect-01-t.html
    http://www.w3.org/Graphics/SVG/Test/20061213/htmlEmbedHarness/full-shapes-rect-01-t.html

  paint-vfill-204-t.svg 
    - The leaf should have yellow viewport-fill according to pass criteria.

  paint-grad-201-t.svg
    - Should show the rect opaque on top of the star since that's the final stage of the animation.

  linking-refs-204 
    - According to testcase description: "Left bottom; square with green transparent fill with an overlapping circle with a blue transparent fill."

  coords-pAR-201-t
    - All of the 'defer' cases are incorrect in the reference image according to the description.

  animate-elem-86-t.svg
    - The purple rect should be to the right.



Other minor issues:

  linking-refs-205
    - the link there is a 404, is that intentional?

  interact-order-06-t.svg
    - the go back link is broken if you click on the second string there, it should link back to the svggen directory, right?

  interact-focus-212-t.svg
    - The image "../images/earth.jpg" is missing

  interact-dom-02-t.svg
    - This test is different from the 1.1 test, because it doesn't listen for the SVGLoad event.

  udom-event-201-t.svg
    - Would prefer if it used SVGLoad instead of load.



Wrong revision number in reference image:

  All the media-video-* tests

  Most of the media-audio-* tests

  Most of the media-anim-* tests

  All of the media-alevel-* tests

  (...and many others)


Cheers
/Erik

-- 
Erik Dahlstrom, Core Technology Developer, Opera Software
Co-Chair, W3C SVG Working Group
Personal blog: http://my.opera.com/macdev_ed
Received on Tuesday, 23 September 2008 14:02:05 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 6 January 2015 21:20:09 UTC