W3C home > Mailing lists > Public > public-shex-dev@w3.org > October 2017

Re: [primer] Minor comments on the primer

From: tombaker via GitHub <sysbot+gh@w3.org>
Date: Thu, 19 Oct 2017 06:46:49 +0000
To: public-shex-dev@w3.org
Message-ID: <issue_comment.created-337814979-1508395608-sysbot+gh@w3.org>
Hi Lars,

Your detailed comments are much appreciated!  I am swamped this week with
two major deadlines for next week (and DC-2017) but look forward to
fixing these immediately thereafter.

Many thanks,
Tom

On Thu, Oct 12, 2017 at 08:05:37AM +0000, Lars G. Svensson wrote:
> # 2.2 Basic Terminology
> The text reads "all arcs in or out". I propose to change this to "all incoming or outgoing arcs"
> 
> # 3 ShEx Essentials
> Text reads "in which an Issue which is submitted". That ought to be "in which an Issue is submitted" otherwise there's something missing in the sentence.
> In the image of the graph the assignee is missing. Is that on purpose?
> 
> # 3.1 Node constraints
> The definition of value set shows an example where the set consists of two IRIs. It would be helpful to add text or an example that shows how this works with literals and/or numbers. E. g. 
> ´´´my:IssueShape {
>     ex:numberOfVerifications [ 1 3 5 ]
> }´´´
> (saying that the issue must be verified 1, 3 or five times; stupid example but you get the gist...).
> 
> # 3.4 Combining Value Constraints
> I don't quite understand this example. The result shape map references inst:User1 and inst:User3 but none of those appear in the passing/failing data. Are those instances the same as <http://hr.example/id#123> and <http://hr.example/id#abc> ?
> 
> # 3.7 Value Sets
> In the example you use inverse constraints (´´´^ex:hasIssue´´´) but don't introduce those until later in the document which is confusing for the reader. It would be better to say that the example uses an inverse constraint and make a reference to 4.1.
> The Result Shape Map says that ´´´inst:Issue3´´´ fails against ´´´my:IssueShape``` because ´´´my:Product3´´´ is not in range of ´´´ex:hasIssue´´´. In my view that is not correct. ´´´my:Product3´´´ is not in the *domain* of ´´´ex:hasIssue´´´ or not not in range of ´´´^ex:hasIssue´´´ (the inverse constraint).
> 
> # 4.1 Inverse Triple Constraints
> Is there a reason that the data is not split into passing and failing data? ```inst:User2``` is failing data.
> 
> # 4.6 Repeated Properties
> In this section the usual Result Shape Map is missing.
> 
> Best,
> 
> Lars
> 
> -- 
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly or view it on GitHub:
> https://github.com/shexSpec/primer/issues/10

-- 
Tom Baker <tom@tombaker.org>


-- 
GitHub Notification of comment by tombaker
Please view or discuss this issue at https://github.com/shexSpec/primer/issues/10#issuecomment-337814979 using your GitHub account
Received on Thursday, 19 October 2017 06:46:50 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 4 June 2019 11:00:16 UTC