- From: Harald Alvestrand <harald@alvestrand.no>
- Date: Fri, 16 May 2014 10:03:29 +0200
- To: public-ortc@w3.org
- Message-ID: <5375C651.3000800@alvestrand.no>
On 05/16/2014 09:22 AM, Jason Ausborn wrote:
> I believe that the WebIDL Type of "unsigned int" should be changed to
> either unsigned short, unsigned long, or unsigned long long. Reason
> being, the "int" Type is not listed as a Type for WebIDL (from my
> understanding).
There's been general advice given on WebIDL that one should always use
"long" or "unsigned long" by default, (and use "double" not "float").
Value range restrictions belong as comments, not types, I think.
>
> Areas are highlighted yellow below:
>
> 8.1 RTCRtpUnhandled
>
> dictionary *RTCRtpUnhandled* {
> unsigned int ssrc
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpUnhandled-ssrc>;
>
> unsigned byte payloadType
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpUnhandled-payloadType>;
>
> DOMString? receiverId
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpUnhandled-receiverId>;
>
> };
>
>
> 8.3 dictionary RTCRtpCodec
>
> dictionary *RTCRtpCodec* {
> DOMString name
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpCodec-name>
> = "";
> unsigned int? hzRate
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpCodec-hzRate>
> = null;
> unsigned byte preferredPayloadType
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpCodec-preferredPayloadType>;
>
> unsigned int? numChannels
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpCodec-numChannels>
> = 1;
> Capabilities formats
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpCodec-formats>;
>
> };
>
>
> 8.4 dictionary RTCRtpParameters
>
> dictionary *RTCRtpParameters* {
> DOMString receiverId
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpParameters-receiverId>
> = "";
> sequence<|*RTCRtpCodecParameters*|
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#idl-def-RTCRtpCodecParameters>>
> codecs
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpParameters-codecs>;
> sequence<|*RTCRtpHeaderExtensionParameters*|
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#idl-def-RTCRtpHeaderExtensionParameters>>
> headerExtensions
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpParameters-headerExtensions>;
> sequence<|*RTCRtpEncodingParameters*|
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#idl-def-RTCRtpEncodingParameters>>
> encodings
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpParameters-encodings>;
>
> unsigned int rtcpSsrc
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpParameters-rtcpSsrc>;
>
> };
>
>
> 8.6 dictionary RTCRtpEncodingParameters
>
> dictionary *RTCRtpEncodingParameters* {
> unsigned int? ssrc
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpEncodingParameters-ssrc>
> = null;
> DOMString codecName
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpEncodingParameters-codecName>
> = "";
> |*RTCRtpFecParameters*|
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#idl-def-RTCRtpFecParameters>?
> fec
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpEncodingParameters-fec>
> = null;
> |*RTCRtpRtxParameters*|
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#idl-def-RTCRtpRtxParameters>?
> rtx
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpEncodingParameters-rtx>
> = null;
> double priority
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpEncodingParameters-priority>
> = 1.0;
> double? maxBitrate
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpEncodingParameters-maxBitrate>
> = null;
> double minQuality
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpEncodingParameters-minQuality>
> = 0;
> double frameratebias
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpEncodingParameters-frameratebias>
> = 0.5;
> double scale
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpEncodingParameters-scale>
> = null;
> double framerate
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpEncodingParameters-framerate>
> = null;
> double quality
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpEncodingParameters-quality>
> = null;
> boolean active
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpEncodingParameters-active>
> = true;
> DOMString? encodingId
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpEncodingParameters-encodingId>;
>
> sequence<DOMString> dependencyEncodingIds
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpEncodingParameters-dependencyEncodingIds>;
>
> };
>
>
> 8.8 dictionary RTCRtpFecParameters
>
> dictionary *RTCRtpFecParameters* {
> unsigned int? ssrc
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpFecParameters-ssrc>
> = null;
> DOMString mechanism
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpFecParameters-mechanism>;
>
> };
>
>
> 8.9 dictionary RTCRtpRtxParameters
>
> dictionary *RTCRtpRtxParameters* {
> unsigned int? ssrc
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpRtxParameters-ssrc>
> = null;
> };
>
>
> 11.3.3 dictionary RTCSctpCapabilities
>
> dictionary *RTCSctpCapabilities* {
> unsigned int maxMessageSize
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCSctpCapabilities-maxMessageSize>
> = null;
> };
>
>
> --------------------------
>
>
> Also, I did not find an "unsigned byte" type for WebIDL (from my
> understanding)
>
> Areas are highlighted yellow below:
>
>
> 8.1 RTCRtpUnhandled
>
> dictionary *RTCRtpUnhandled* {
> unsigned int ssrc
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpUnhandled-ssrc>;
>
> unsigned byte payloadType
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpUnhandled-payloadType>;
>
> DOMString? receiverId
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpUnhandled-receiverId>;
>
> };
>
>
> 8.3 dictionary RTCRtpCodec
>
> dictionary *RTCRtpCodec* {
> DOMString name
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpCodec-name>
> = "";
> unsigned int? hzRate
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpCodec-hzRate>
> = null;
> unsigned byte preferredPayloadType
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpCodec-preferredPayloadType>;
>
> unsigned int? numChannels
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpCodec-numChannels>
> = 1;
> Capabilities formats
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpCodec-formats>;
>
> };
>
>
> 8.5 dictionary RTCRtpCodecParameters
>
> dictionary *RTCRtpCodecParameters* {
> unsigned byte payloadType
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpCodecParameters-payloadType>;
>
> |*RTCRtpCodec*|
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#idl-def-RTCRtpCodec>
> codec
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpCodecParameters-codec>;
>
> Settings formats
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpCodecParameters-formats>;
>
> Settings rtcpFeedback
> <http://ortc.org/wp-content/uploads/2014/05/ortc.html#widl-RTCRtpCodecParameters-rtcpFeedback>;
>
> };
>
> --------------
>
> HTH,
>
> Jason
Received on Friday, 16 May 2014 08:04:00 UTC