RE: GSoC Final Project Deadlines

On Thursday, September 19, 2013 8:37 PM, vikash agrawal wrote:
>> - The produced JSON-LD data should use an external context
>> (http://json-ld.org/contexts/linkedin.jsonld)
>>
>> Done.
>You use two external contexts. Please combine them into one.
>
> Over IRC Manu had said to keep it that way. So I wrote in so.  

Are you sure you understood him correctly? Looking at linkedin.jsonld I see a lot of properties using schema.org anyway so there's not much value in referencing both contexts from the document. The simplest fix would be to reference the schema.org context from the linkedin one but I don't think that's really necessary.


>> - Skills are not of type schema:CreativeWork
>>
>> Removed.
> Since all of them are now blank nodes with a single property (name) it's
> probably better to simply replace the array of objects with an array of
> strings ("skills": [ "JSON-LD", "programming", "..." ])
>
> Initially it was this way, and then it was told to keep it like this { 'name' : ...}

I don't have a strong opinion on that. So leave it as is for now.



>> - The whole thing is a blank node but you've got the publicProfileUrl,
>> use it (don't use schema.org/url for that)
>>
>>- You seem to discard a whole lot of information (start/end dates, degrees,
>> languages, ...)
>>
>> Will try to enhance more in the next iteration. :)
>Still not done even though you said on IRC the other day that the tool is ready for review. Sorry, I don't have the >time to review stuff several times and re-check whether all the previous feedback I have been giving has been >implemented.
>
>
> I meant the polishing of tools, in terms of UI.

Right, but that has nothing to do with the UI.


>> - This is a personal preference: Please don't ask for and don't
>> include the email address. Most people are very cautious of handing out
>> their email address (at least in Europe).
>>
>> Done.
>Only partly. The tool still requests the email address from LinkedIn. Most people don't want that to happen. The >checkbox you added only removes it from the JSON-LD output
>
>
> Markus, well the checkbox works the way it should. When checked it adds email
> field and when unchecked it removes it. 
>
> If you want the request shouldn't be fired then I will do it that way, but everytime
> a new request will be fired when the checkbox for email would be checked or unchecked.

So? I don't want my email address to leave LinkedIn, that's the whole reason why I asked for this change.

 
--
Markus Lanthaler
@markuslanthaler

Received on Friday, 20 September 2013 13:54:10 UTC