- From: Raphael Kubo da Costa via GitHub <sysbot+gh@w3.org>
- Date: Thu, 25 Feb 2021 14:50:05 +0000
- To: public-device-apis-log@w3.org
@annevk @domenic @kenchris @marcoscaceres I think this PR is finally ready. All uses of "in parallel" have been audited, I think `WakeLock.request()` is free of race conditions when manipulating `[[ActiveLocks]]` and we are not checking anything from the main event loop when in parallel. The questions that seems to remain is there should be a queued task to fire the "release" event and change `[[Released]]` to `true`, which is what motivated #293 in the first place. My understanding based on [this comment](https://github.com/w3c/screen-wake-lock/pull/299#issuecomment-777600796) above is that in this case there is no need to queue a task and we can do things directly instead. There are further cleanups that @domenic is doing in #307 related to the use of "responsible document"; I think it makes sense to land them separately there. -- GitHub Notification of comment by rakuco Please view or discuss this issue at https://github.com/w3c/screen-wake-lock/pull/299#issuecomment-785950212 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Thursday, 25 February 2021 14:50:08 UTC