Re: [screen-wake-lock] "Release a wake lock": should we queue a task to fire the "release" event? (#293)

> Is it intentional that the `release` event is always dispatched, even if the OS said no?

It might make sense to do something different later, but for now yeah, we always remove the lock from `[[ActiveLocks]]` and fire the event when this algorithm is called.

> Usually you queue a task if you want to announce the result of some other thread, but that's not what's happening here. (I.e., flipping the order of step 5 and 6 is a no-op...)

OK, so does it make more sense to stop deferring the event and the change to `[[Released]]` here then? @marcoscaceres suggested queuing a task back in #242, but I didn't ask for a rationale back then :/

-- 
GitHub Notification of comment by rakuco
Please view or discuss this issue at https://github.com/w3c/screen-wake-lock/issues/293#issuecomment-770940207 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Monday, 1 February 2021 15:28:14 UTC