Re: [css-writing-modes-3] Additional review of vertical-alignment-new-00? tests

Le 2015-09-02 10:54, 塩澤 元 a écrit :
> Hi Gérard,
> 
> I have fixed.
> https://hg.csswg.org/test/rev/b8572658320e
> 
> And I have changed other tests and renamed it! (and removed all old 
> tests.)
> https://hg.csswg.org/test/rev/02f4c97c2264
> https://hg.csswg.org/test/rev/e8f5c3031748

In

https://hg.csswg.org/test/rev/e8f5c3031748

are you sure it was okay to remove *all* those 32 tests? I wonder if a 
few just needed to be adjusted. I know there were some tests with 
'text-orientation: sideways-right' and
'text-orientation: upright' ... Are you planning to re-create some tests 
with 'text-orientation: sideways-right' and 'text-orientation: upright' 
and vertical-align ?



> https://hg.csswg.org/test/rev/b3c0ccd280f3
> 
> Hajime.


In

http://test.csswg.org/source/css-writing-modes-3/vertical-alignment-008-ref.xht

line 8:
     img
     {
       vertical-align: top;
     }

     img#orange
     {
       padding-top: 30px; /* = the height of first character */
       padding-left: 30px;
     }

can be completely replaced with only (more concise)

     img#orange
     {
       padding-left: 30px;
     }


- - - - - - - - - - - -


Please add

<link rel="reviewer" title="Gérard Talbot" 
href="http://www.gtalbot.org/BrowserBugsSection/css21testsuite/" /> <!-- 
2015-09-03 -->

to all

http://test.csswg.org/source/css-writing-modes-3/vertical-alignment-00[2-9].xht
tests and to their related reference files.

Gérard
-- 
Test Format Guidelines
http://testthewebforward.org/docs/test-format-guidelines.html

Test Style Guidelines
http://testthewebforward.org/docs/test-style-guidelines.html

Test Templates
http://testthewebforward.org/docs/test-templates.html

CSS Naming Guidelines
http://testthewebforward.org/docs/css-naming.html

Test Review Checklist
http://testthewebforward.org/docs/review-checklist.html

CSS Metadata
http://testthewebforward.org/docs/css-metadata.html

Received on Thursday, 3 September 2015 04:55:03 UTC