[css-writing-modes-3] Review comments on orthogonal-parent-shrink-to-fit-001a

Koji,


http://test.csswg.org/source/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001a.html

line 11: font:25px Ahem;

Whenever you set a font-size for the Ahem font, you need to set the 
line-height as well. Otherwise, line-height is, by default, 'normal' and 
'normal' for IE11 and Webkit-based browsers for the Ahem font is 1.2 
while it is 1.0 for Firefox.

I suggest

line 11: font:25px/1 Ahem;

Ahem Usage
http://testthewebforward.org/docs/test-style-guidelines.html#special-fonts

----------

line 12: clear:both;

'clear' can only apply and can only have a rendering effect in presence 
of floats and if there is a float earlier in the source document. So, 
here, at line 12, 'clear: both' has no impact, no influence, no 
relevance. You can safely remove 'clear: both'.

'clear: both' makes sense though in 
orthogonal-parent-shrink-to-fit-001.html
but not in orthogonal-parent-shrink-to-fit-001?.html

----------

line 13: margin-top:.2em;

You can safely remove this declaration since the preceding <p>'s 
margin-bottom is 1em and so there will be a margin-collapse of both 
blocks' margin. max(1em, 0) or max(1em, 0.2em) is going to be the same 
anyway.

---------

http://test.csswg.org/source/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001.html

I think you should not create a "combo" test, a meta-test for all these 
orthogonal scenarios and situations. Each of these sub-tests are 
somewhat complex (definitely not basic tests) and not easily obvious ... 
at least to me...

I would filename-rename those 1a-1g tests into separate, distinct tests 
and not make them part of a "combo" test.

Gérard
-- 
Test Format Guidelines
http://testthewebforward.org/docs/test-format-guidelines.html

Test Style Guidelines
http://testthewebforward.org/docs/test-style-guidelines.html

Test Templates
http://testthewebforward.org/docs/test-templates.html

CSS Naming Guidelines
http://testthewebforward.org/docs/css-naming.html

Test Review Checklist
http://testthewebforward.org/docs/review-checklist.html

CSS Metadata
http://testthewebforward.org/docs/css-metadata.html

Received on Thursday, 14 May 2015 04:38:46 UTC