W3C home > Mailing lists > Public > public-css-testsuite@w3.org > March 2015

Re: [css3-ui] cursor-image-png-038: incorrect link to image

From: Chris Lilley <chris@w3.org>
Date: Tue, 24 Mar 2015 12:29:49 +0100
Message-ID: <842140470.20150324122949@w3.org>
To: Gérard Talbot <css21testsuite@gtalbot.org>
CC: Public CSS Test suite mailing list <public-css-testsuite@w3.org>
Hello Gérard,

Monday, March 23, 2015, 10:01:05 PM, you wrote:

> Le 2015-03-23 12:01, Chris Lilley a écrit :
>> C) A larger set of tests extensively checks PNG cursor support in
>> depth (no need to run these if 001 and 002 fail). All possible color
>> types (greyscale, RGB, grey+A, RGBA, indexed) are tested with both
>> interlaced and non-interlaced images, at various bit depths.
>> 
>> PNG alpha and transparency (tRNS) are tested, also gamma correction.
>> Lastly there are some tests with invalid PNG images, to check the
>> fallback is used.
>> 
>> All images are from the PNG test suite, and the images were verified
>> for correctness to the PNG spec using pngcheck -v.
>> 
>> cursor-image-png-001.html to cursor-image-png-043.html

> Chris,

> These tests are interesting.

> One is incorrect:

> http://test.csswg.org/shepherd/testcase/cursor-image-png-038/

> http://test.csswg.org/source/css-ui-3/cursor-image-png-038.html

Thanks, I see what went wrong. Realising that the supporting files
needed to be in a support directory I did a global edit which
corrected the css but did not correct images included in the html.

-38, -39 and -40 were affected.

> Links to images are incorrect, an alt attribute are missing also, image
> flag is missing.


> line 16 to 21:  <img src="PTS/g03n0g16.png"><br />

> should be

> line 16 to 21:  <img src="support/PTS/g03n0g16.png" alt="Image download
> support must be enabled"><br />

Yes, all the ones with reference images in the html need image flag
and alt. Now added.

Should the ones that add reference images via CSS also have the image
flag?

>> D) Similar tests will be needed for other cursor formats,

> Any chance of testing .csr format?

I'm not finding a definition of that, got a pointer?

Happy to add if I can find a way to make such an image and if at least
one browser supports it as a cursor format.


>> some of which
>> (such as .cur) do not have adequate documentation.

> .cur is a Microsoft-proprietary file format right now ...

Yes, and it is documented poorly (an MSDN article and a few blog
posts summarising updates over the last decade).  I have invited
Microsoft to put together a specification and to do a W3C Member
Submission so that it is at least documented and archived.

I see from
https://beradrian.wordpress.com/2008/01/08/cross-browser-custom-css-cursors/
that Internet Explorer (used to?) have a bug about the base for
relative URIs for cursors. It looks as if I should add a test where
the base URI of the html and of the CSS are different.

Thanks for your review, Gérard.

Oh - mercurial woes:

Chris@M6700 ~/csswg/csstest/test/css-ui-3
$ hg commit -m "incorporate review comments from Gerard"
css-ui-3/cursor-image-png-038.html
css-ui-3/cursor-image-png-039.html
css-ui-3/cursor-image-png-040.html
committed changeset 7087:29c0875f41d1

Chris@M6700 ~/csswg/csstest/test/css-ui-3
$ hg pull -u
pulling from https://hg.csswg.org/test/
searching for changes
adding changesets
adding manifests
adding file changes
added 10 changesets with 30 changes to 15 files (+1 heads)
not updating: not a linear update
(merge or update --check to force update)

Chris@M6700 ~/csswg/csstest/test/css-ui-3
$ hg merge
7 files updated, 0 files merged, 2 files removed, 0 files unresolved
(branch merge, don't forget to commit)

Chris@M6700 ~/csswg/csstest/test/css-ui-3
$ hg commit -m "incorporate review comments from Gerard"
abort: No such file or directory: '/home/Chris/csswg/csstest/test/resources'

Chris@M6700 ~/csswg/csstest/test/css-ui-3
$ hg push
pushing to https://hg.csswg.org/test/
no changes made to subrepo tools/apiclient since last push to http://hg.csswg.org/dev/apiclient
no changes made to subrepo tools/w3ctestlib since last push to http://hg.csswg.org/dev/w3ctestlib
searching for changes
abort: push creates new remote head 29c0875f41d1!
(merge or see "hg help push" for details about pushing new heads)
[1]+  Exit 1                  explorer .


hmm.

Chris@M6700 ~/csswg/csstest/test/css-ui-3
$ hg commit -m "merge"
abort: No such file or directory: '/home/Chris/csswg/csstest/test/resources'

Chris@M6700 ~/csswg/csstest/test/css-ui-3
$ mkdir ../resources

Chris@M6700 ~/csswg/csstest/test/css-ui-3
$ hg commit -m "merge"
fatal: Not a git repository (or any of the parent directories): .git
abort: git rev-parse error 128 in resources

oh no not this again.

-- 
Best regards,
 Chris Lilley, Technical Director, W3C Interaction Domain
Received on Tuesday, 24 March 2015 11:30:02 UTC

This archive was generated by hypermail 2.4.0 : Friday, 20 January 2023 19:58:21 UTC