Re: fixed new inline-block alignement test (complete review)

Le 2015-07-15 19:58, 塩澤 元 a écrit :
> Gérard,
> 
> I have submitted.
> 
> https://hg.csswg.org/test/rev/74cf2d8eb799
> 
> 

Hajime,

>> 5-
>> 
>> 
>> http://test.csswg.org/source/css-writing-modes-3/inline-block-alignment-new-009.xht
>> 
>> I believe inline-block-alignment-new-009.xht's reference file should 
>> be
>> 
>> inline-block-alignment-new-007-ref.xht and not
>> inline-block-alignment-new-006-ref.xht
>> 
>> and inline-block-alignment-new-009's pass-fail-conditions should be
>> 
>> <p>Test passes if the <strong>right edge</strong> of an irregular 
>> polygon
>> is straight and unbroken.</p>
>> 
>> and not left edge.
>> 
>> 

Your
InlineBlockAlphabeticalAlignment.PNG
re-attached to this email confirms my opinion:

inline-block-alignment-new-009.xht's reference file should be
inline-block-alignment-new-007-ref.xht
and not
inline-block-alignment-new-006-ref.xht

Please adjust inline-block-alignment-new-009.xht accordingly.

>> 6-
>> 
>> 
>> http://test.csswg.org/source/css-writing-modes-3/inline-block-alignment-new-010.xht
>> 
>> I believe inline-block-alignment-new-010.xht's reference file should 
>> be
>> 
>> inline-block-alignment-new-006-ref.xht and not
>> inline-block-alignment-new-007-ref.xht
>> 
>> and inline-block-alignment-new-010's pass-fail-conditions should be
>> 
>> <p>Test passes if the <strong>left edge</strong> of an irregular 
>> polygon
>> is straight and unbroken.</p>
>> 
>> and not right edge.


Your
InlineBlockAlphabeticalAlignment.PNG
re-attached to this email confirms my opinion:

inline-block-alignment-new-010.xht's reference file should be
inline-block-alignment-new-006-ref.xht
and not
inline-block-alignment-new-007-ref.xht


Please adjust inline-block-alignment-new-010.xht accordingly.


> Now I have another thought. Now I think that the reference files must 
> have
> four pattern for alphabetical baseline testcase.
> 
> - (1) vertical-rl + sideways-right (= vertical-rl + sideways)
> - (2) vertical-rl + sideways-left
> - (3) vertical-lr + sideways-right
> - (4) veritcal-lr + sideways-left (= vertical-lr + sideways)
> 
> I've attached the image which represents above all pattern.
> In the image, "ABCDEFG" is the first line in inline-block, "HIJKLMN" is 
> the
> last line in inline-block.
> 
> What do you think about?


I agree with your InlineBlockAlphabeticalAlignment.PNG (under current 
spec) but...

'writing-mode: sideways-left'

has a good chance of being adopted by CSSWG ... and then
'text-orientation: sideways-left' would be dropped according to

http://lists.w3.org/Archives/Public/www-style/2015Jul/0060.html

Gérard
-- 
Test Format Guidelines
http://testthewebforward.org/docs/test-format-guidelines.html

Test Style Guidelines
http://testthewebforward.org/docs/test-style-guidelines.html

Test Templates
http://testthewebforward.org/docs/test-templates.html

CSS Naming Guidelines
http://testthewebforward.org/docs/css-naming.html

Test Review Checklist
http://testthewebforward.org/docs/review-checklist.html

CSS Metadata
http://testthewebforward.org/docs/css-metadata.html