W3C home > Mailing lists > Public > public-css-testsuite@w3.org > January 2015

Re: Review of 'row-progression-01[1-8].xht'

From: Shiozawa, Hajime <hajime.shiozawa@gmail.com>
Date: Wed, 21 Jan 2015 23:45:23 +0900
Message-ID: <CAHSwuKO9BXFsn+h_JuDsTDXmmiG6m_RDwcmW-wtT8x1Y1S=MNg@mail.gmail.com>
To: Gérard Talbot <css21testsuite@gtalbot.org>
Cc: Public CSS Test suite mailing list <public-css-testsuite@w3.org>, "Elika 'fantasai' Etemad" <fantasai@inkedblade.net>, Koji Ishii <kojiishi@gluesoft.co.jp>
Thank you for your reviewing.
I have submitted.

https://hg.csswg.org/test/rev/363969572bdf

Thank you.


2015-01-21 5:14 GMT+09:00 Gérard Talbot <css21testsuite@gtalbot.org>:

> Le 2015-01-20 09:39, 塩澤 元 a écrit :
>
>> Hi Gérard,
>>
>> I have submitted the modified files.
>>
>> https://hg.csswg.org/test/rev/1ddb78bd81c4
>> https://hg.csswg.org/test/rev/3e300a51978d
>>
>
> http://test.csswg.org/source/css-writing-modes-3/table-
> column-order-002.xht
>
> line 49:   <!-- The right-most "S" -->
>   <tr><td><!-- bottommost column -->AA &nbsp;B &nbsp;C D&nbsp;</td><td>EE
> F&nbsp; G&nbsp; H&nbsp;</td><td><!-- topmost column -->J &nbsp; K &nbsp; L
> &nbsp; MMM</td></tr>
>
>   <!-- The left-most "S" -->
> line 53:  <tr><td><!-- bottommost column -->NN O Q R</td>
>
> Please reuse the same character code sequence. I suggest:
>
>   <!-- The right-most "S" -->
>   <tr><td><!-- bottommost column -->AA B C D</td><td>EE F&nbsp; G&nbsp;
> H&nbsp;</td><td><!-- topmost column -->J &nbsp; K &nbsp; L &nbsp;
> MMM</td></tr>
>
>   <!-- The left-most "S" -->
>   <tr><td><!-- bottommost column -->NN O Q R</td>
>
>
> -----------
>
> http://test.csswg.org/source/css-writing-modes-3/table-
> column-order-004.xht
>
>   <meta content="This test checks that colspanned cells in a table are
> handled according to a top-to-bottom inline flow direction." name="assert"
> />
>
> This may need more explanation. The table's 'direction' is 'rtl'; so the
> colspanning will involve the column above, not the column below.
>
> <table style="direction: rtl; writing-mode: vertical-rl;">
>   <tr id="row-right"><td>r</td><td>r</td><td>r</td></tr>
>   <tr><td id="column-below">a</td><td colspan="2">x</td></tr>
>   <tr id="row-left"><td>l</td><td>l</td><td>l</td></tr>
> </table>
>
> In a table with 'direction' set to 'rtl', columns are ordered from
> bottom-to-top; so, spanned cells also work like that. Your text assert does
> not mention this.
>
>
> I now think row-progression-004 and 005's text asserts need to be adjusted
> too.
>
>  I removed the test-case for row-span (row-progression-015 and 016) and for
>> thead-tbody-tfoot (row-progression-017 and 018), because I think that
>> these
>> test-case are for checking only the correctness of row-progression.
>>
>> Hajime.
>>
>
> Okay.
>
> Gérard
>
>
>
>>
>>
>> 2015-01-16 13:14 GMT+09:00 Gérard Talbot <css21testsuite@gtalbot.org>:
>>
>>  Le 2015-01-15 08:49, 塩澤 元 a écrit :
>>>
>>>  Hi Gérard,
>>>>
>>>> Thank you for your reviewing!
>>>> OK, I will apply your review to testcase which I submitted in last
>>>> week...
>>>>
>>>>
>>>>  Hajime,
>>>
>>> I suggest to adapt, modify the code and then filename-rename those tests
>>> as
>>>
>>> table-column-order-002, table-column-order-003, table-column-order-004,
>>> table-column-order-005, table-column-order-006, ...
>>> and that will be helpful, useful.
>>>
>>> The byte/character reorder with 'unicode-bidi: bidi-override' is
>>> difficult
>>> stuff... which I would leave to Richard Ishida...
>>>
>>> Gérard
>>>
>>>
>>>
>>>  2015-01-12 13:19 GMT+09:00 Gérard Talbot <css21testsuite@gtalbot.org>:
>>>>
>>>>  Le 2015-01-11 19:02, Gérard Talbot a écrit :
>>>>
>>>>>
>>>>>  Le 2015-01-11 03:22, 塩澤 元 a écrit :
>>>>>
>>>>>
>>>>>>  Gérard,
>>>>>>
>>>>>>>
>>>>>>> I have submitted 'direciton: rtl' version.
>>>>>>> http://hg.csswg.org/test/rev/77111522a3b0
>>>>>>>
>>>>>>> Please review these test-cases.
>>>>>>>
>>>>>>>
>>>>>>>  http://test.csswg.org/source/css-writing-modes-3/row-
>>>>>> progression-011.xht
>>>>>>
>>>>>> http://test.csswg.org/source/css-writing-modes-3/row-
>>>>>> progression-012.xht
>>>>>>
>>>>>> http://test.csswg.org/source/css-writing-modes-3/row-
>>>>>> progression-013.xht
>>>>>>
>>>>>> http://test.csswg.org/source/css-writing-modes-3/row-
>>>>>> progression-014.xht
>>>>>>
>>>>>> http://test.csswg.org/source/css-writing-modes-3/row-
>>>>>> progression-015.xht
>>>>>>
>>>>>> http://test.csswg.org/source/css-writing-modes-3/row-
>>>>>> progression-016.xht
>>>>>>
>>>>>> http://test.csswg.org/source/css-writing-modes-3/row-
>>>>>> progression-017.xht
>>>>>>
>>>>>> http://test.csswg.org/source/css-writing-modes-3/row-
>>>>>> progression-018.xht
>>>>>>
>>>>>>
>>>>>> Hajime,
>>>>>>
>>>>>> I think those tests should not be using 'unicode-bidi'... unless you
>>>>>> want to specifically test directionality of text inside table cells.
>>>>>>
>>>>>> I think your tests - without use of 'unicode-bidi' - should be about
>>>>>> *_table column ordering_*; how 'direction:rtl' set on a table element
>>>>>> affects table column order.
>>>>>>
>>>>>> When you read the spec and a testable statement of the spec, you want
>>>>>> to create a test that will check one and one single aspect of the spec
>>>>>> and one and only one statement of the spec. And you want to create
>>>>>> filenames for test and test assertion text that will be coherent.
>>>>>>
>>>>>> When I now rethink this, I do not see how we could create more tests
>>>>>> or other tests regarding table rows progression. By definition,
>>>>>> 'direction: rtl' and 'unicode-bidi: bidi-override' are not supposed to
>>>>>> have any impact, any rendering effect on table row progression to
>>>>>> begin with! But 'direction: rtl' should have an impact, a rendering
>>>>>> effect on columns order.
>>>>>>
>>>>>>
>>>>>>  I have re-read the spec again and checked a bunch of 'direction' and
>>>>> 'unicode-bidi' tests we did in CSS2.1 test suite
>>>>>
>>>>> http://test.csswg.org/suites/css2.1/nightly-unstable/html4/
>>>>> chapter-9.htm#s9.10
>>>>>
>>>>> and clearly this is the case.
>>>>>
>>>>> 1-
>>>>> Only writing-mode has a rendering effect on row progression (or, if you
>>>>> prefer, row right-to-left order for 'writing-mode: vertical-rl' tables
>>>>> or
>>>>> row left-to-right order for 'writing-mode: vertical-lr').
>>>>>
>>>>> 2- Setting 'direction' on a table element only has a rendering effect
>>>>> on
>>>>> columns order (or, if you prefer, column top-to-bottom order or column
>>>>> bottom-top order)
>>>>>
>>>>> 3- setting direction on a block container sets the text direction but
>>>>> bytes and characters are not reordered (or bidi-reordered); you need
>>>>> 'unicode-bidi: bidi-override' to do that.
>>>>>
>>>>>
>>>>>  Are your 'row-progression-01[1-8].xht' tests a waste of time? No. They
>>>>>
>>>>>  should probably a) be filename-renamed b) with new <title> and c) with
>>>>>> new text assert and check how 'unicode-bidi: override' does to text
>>>>>> directionality in table cells and another version of those same
>>>>>> 'row-progression-01[1-8].xht' tests should be about table column
>>>>>> order.
>>>>>>
>>>>>> I'll try to create an example of this later.
>>>>>>
>>>>>>
>>>>>>  Hajime, here's the example I had in mind. I took your
>>>>>
>>>>> http://test.csswg.org/source/css-writing-modes-3/row-
>>>>> progression-011.xht
>>>>>
>>>>> and then created 2 distinct, modified variants of it:
>>>>>
>>>>> http://www.gtalbot.org/BrowserBugsSection/
>>>>> CSS3WritingModes/s21direction-
>>>>> table-column-order-011-Hajime.xht
>>>>>
>>>>> and
>>>>>
>>>>> http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s21-block-
>>>>> override-table-cells-011-Hajime.xht
>>>>>
>>>>> Chrome 39 must have a bug with the rendering of "H&nbsp;" and "V&nbsp;"
>>>>> in
>>>>> s21direction-table-column-order-011-Hajime.xht test because it fails,
>>>>> if
>>>>> I'm correct, to start the 4th line box with the H (or V) instead of the
>>>>> non-breaking-space.
>>>>>
>>>>> IE11 fails completely s21direction-table-column-order-011-Hajime.xht
>>>>>
>>>>> IE11 does not, it seems, support 'unicode-bidi: bidi-override' for
>>>>> vertical-rl tables.
>>>>>
>>>>> Gérard
>>>>>
>>>>> --
>>>>> Test Format Guidelines
>>>>> http://testthewebforward.org/docs/test-format-guidelines.html
>>>>>
>>>>> Test Style Guidelines
>>>>> http://testthewebforward.org/docs/test-style-guidelines.html
>>>>>
>>>>> Test Templates
>>>>> http://testthewebforward.org/docs/test-templates.html
>>>>>
>>>>> CSS Naming Guidelines
>>>>> http://testthewebforward.org/docs/css-naming.html
>>>>>
>>>>> Test Review Checklist
>>>>> http://testthewebforward.org/docs/review-checklist.html
>>>>>
>>>>> CSS Metadata
>>>>> http://testthewebforward.org/docs/css-metadata.html
>>>>>
>>>>>
>>>>>  --
>>> Test Format Guidelines
>>> http://testthewebforward.org/docs/test-format-guidelines.html
>>>
>>> Test Style Guidelines
>>> http://testthewebforward.org/docs/test-style-guidelines.html
>>>
>>> Test Templates
>>> http://testthewebforward.org/docs/test-templates.html
>>>
>>> CSS Naming Guidelines
>>> http://testthewebforward.org/docs/css-naming.html
>>>
>>> Test Review Checklist
>>> http://testthewebforward.org/docs/review-checklist.html
>>>
>>> CSS Metadata
>>> http://testthewebforward.org/docs/css-metadata.html
>>>
>>>
> --
> Test Format Guidelines
> http://testthewebforward.org/docs/test-format-guidelines.html
>
> Test Style Guidelines
> http://testthewebforward.org/docs/test-style-guidelines.html
>
> Test Templates
> http://testthewebforward.org/docs/test-templates.html
>
> CSS Naming Guidelines
> http://testthewebforward.org/docs/css-naming.html
>
> Test Review Checklist
> http://testthewebforward.org/docs/review-checklist.html
>
> CSS Metadata
> http://testthewebforward.org/docs/css-metadata.html
>



-- 
# 塩澤 元 (Shiozawa, Hajime)
# mail: hajime.shiozawa@gmail.com
Received on Wednesday, 21 January 2015 14:45:51 UTC

This archive was generated by hypermail 2.4.0 : Friday, 20 January 2023 19:58:20 UTC