Re: CSS Grid Layout Test Suite Plan

On Apr 8, 2015, at 7:00 AM, Manuel Rego Casasnovas <rego@igalia.com> wrote:

> Hi there,
> 
> I've been working for a while in the CSS Grid Layout test suite.
> At the beginning Gérard Talbot (big thanks!) was helping me with the
> tests review, and a few tests have landed under:
> http://test.csswg.org/shepherd/search/testcase/spec/css-grid-1/
> 
> He doesn't have time now for grid, but I've kept working creating some
> new tests and sending small pull-requests to the github repository:
> https://github.com/w3c/csswg-test/pulls?q=is%3Aopen+label%3Aspec%3Agrid+is%3Apr
> 
> However, as I didn't find another reviewer yet it's getting complicated
> to have so many tests in pull-requests as it's becoming a mess try to
> share reference test or other resources.
> 
> So, I'm thinking that maybe it'd be a good idea to merge the
> pull-requests and keep pushing tests to the repository. And eventually
> some reviewer could take a look to them and mark them as accepted (I
> think that was the usual workflow before github).
> 
> If nobody is against this idea, I'll go forward during next week.

That's fine by me.

When you merge the pull requests, please put the text '[merge]' in the comment field, otherwise Shepherd will consider the tests approved.

By putting '[merge]' in the comment, they will be left as 'Submitted for Review'.

Peter