W3C home > Mailing lists > Public > public-css-testsuite@w3.org > November 2013

Re: TestTWF Pull requests needing review (box-sizing-001, box-sizing-002)

From: Rebecca Hauck <rhauck@adobe.com>
Date: Sun, 10 Nov 2013 17:36:48 -0800
To: "Gérard Talbot" <css21testsuite@gtalbot.org>, "Zhang, Zhiqiang" <zhiqiang.zhang@intel.com>
CC: "hayashih@gmail.com" <hayashih@gmail.com>, "kasshisatari@gmail.com" <kasshisatari@gmail.com>, Public CSS testsuite mailing list <public-css-testsuite@w3.org>
Message-ID: <CEA64D6F.1FE53%rhauck@adobe.com>
Hi Gérard,

Now that we're using GitHub, it is much easier for everyone to use its
built-in review tools. GitHub allows for inline comments, which make it
much easier for the reviewer and author to follow and respond. Outside
observers who are interested can also quickly jump in with just one click.
 For an example, see this review done during TestTWF Shenzhen [1].  These
comments will still be emailed to those who are watching the repo or who
have subscribed to the Pull Request.

To do the review in GitHub, follow these steps:

1. Log in to you GitHub account
2. Go the list of PRs ("pull requests") [2]
3. Click on one of them
4. Click on the Commits tab
5. Click on one of the commits (if multiple commits, make sure you're
looking at the most recent version of the file)
6. As you hover over each line of the files in the commit, you'll see a
blue + icon appear in the left margin - click on that to make inline
7. You may also leave general comments on any given file or on the whole
pull request in the bottom comment box.

Let me know if you have questions.


[1] https://github.com/w3c/csswg-test/pull/352
[2] https://github.com/w3c/csswg-test/pulls
[3] https://github.com/w3c/csswg-test/pull/207

On 11/9/13 2:38 AM, ""Gérard Talbot"" <css21testsuite@gtalbot.org> wrote:

>Le Ven 8 novembre 2013 13:33, "Gérard Talbot" a écrit :
>>>> line 6: <link rel="help"
>>>> href="http://www.w3.org/TR/css3-ui/#box-sizing">
>>>> Suggestion:
>>>> <link rel="help" href="http://www.w3.org/TR/css3-ui/#box-sizing"
>>>> title="6.1. 'box-sizing' property">
>>> Added. Though title is not suggested by reftest template.
>> Adding the title helps a bit when there is more than 1 <link rel="help">
>> to spec and if the user/reviewer uses a document (relations) links bar
>> in which case the document links bar will display the title text.
>> See:
>> link-bar-example.html
>> shows how I can use such title attribute for a test like
>> that has 3 <link rel="help">
>Contributions to the CSS 2.1 test suite:
>CSS 2.1 Test suite RC6, March 23rd 2011:
>CSS 2.1 test suite harness:
>Contributing to to CSS 2.1 test suite:
Received on Monday, 11 November 2013 01:35:25 UTC

This archive was generated by hypermail 2.4.0 : Friday, 20 January 2023 19:58:20 UTC