- From: Gérard Talbot <css21testsuite@gtalbot.org>
- Date: Wed, 20 Feb 2013 20:51:00 -0500
- To: "taka" <takaoshiyama@gmail.com>
- Cc: public-css-testsuite@w3.org
Le Sam 16 février 2013 10:51, taka a écrit : > Hi Gerard > Please review again as I have updated here: > http://hg.csswg.org/test/rev/eca8ec6bc6d7 >> line 5: <title>CSS Text Test: text-decoration-line</title> >> >> " >> For specifications other than CSS 2.1, you can include the module name >> somewhere before the colon, like “CSS Selectors Test:†or “CSS >> Test >> (Selectors):â€. Do not include the module version number, since the >> test >> might get reused for the next version. >> " >> >> So here, >> >> <title>CSS Text Decoration Test: text-decoration-line - none</title> >> >> is adequate. > Yes, I did it and for the rest accordingly. >> line 12: <meta name="assert" content="Neither produces nor inhibits >> text >> decoration." /> >> >> I suggest >> <meta name="assert" content="This test checks that >> 'text-decoration-line: none' does not produce any text decoration." /> > Yes, I did it and for the rest accordingly. >> line 14 to 23: as it is, downloading and processing a @font-face 8MB >> font is inappropriate; mplus-1p-regular font (1.3MB) is better but >> still >> not satisfactory. I have no complete solution ready and tested to >> propose right now. > Yes, I did it, though I understand it's a temporary solution. >> line 41: >> <p>Test passes if no line is displayed.</p> >> >> This can confuse testers: line can mean an horizontal rule or it can >> mean a line of text. I propose >> >> <p>Test passes if the 2 "Text sample >> サンプル文" are underlined and >> <strong>identical</strong>.</p> >> >> You can reuse such kind of pass/fail conditions sentence, formulation >> in >> all your tests. > Yes, I did it partially but not all as I believe "underlined" is not > appropriate against an overline, line-through or blink. > I did this as: > <p>Test passes if the 2 "Text sample サンプル文" are > <strong>identical</strong> and <strong>no text decoration</strong>.</p> 1. In http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/text-decoration-line-010.xht and only in text-decoration-line-010.xht I suggest <p>Test passes if the 2 "Text sample サンプル文" are <strong>identical</strong>.</p> Normal people do not know and would not know for sure what "text decoration" is or might be. The pass/fail test conditions sentence should be understandable and clear to anyone and everyone: to your neighbour, to your mailman, to your mother, to your bus driver, etc. Anything else in the source code of tests can be using more technical vocabulary and CSS terminology. ------------- 2. In text-decoration-line-010.xht text-decoration-line-011.xht text-decoration-line-012.xht text-decoration-line-013.xht line 11: <meta name="flags" content="font should" /> please remove the "should" flag. ------------- 3. In text-decoration-line-014.xht line 11: <meta name="flags" content="font should" /> please replace the "should" flag with "may" like this: line 11: <meta name="flags" content="font may" /> Why? Because "Conforming user agents *may* simply not blink the text." http://www.w3.org/TR/css-text-decor-3/#text-decoration-line-property -------------- 4. Please add 2 blank spaces between property_name and property_value in the title text: eg in text-decoration-line-010.xht <title>CSS Text Decoration Test: text-decoration-line-none</title> becomes <title>CSS Text Decoration Test: text-decoration-line - none</title> eg in text-decoration-line-013.xht <title>CSS Text Test: text-decoration-line-line-through</title> becomes <title>CSS Text Test: text-decoration-line - line-through</title> Gérard > > In addition, I set font-size: 1.0em to get better proportion with the > test instruction above, switch to ID selector as there is one occurrence > per page in these testcases. > > regards, -- Contributions to the CSS 2.1 test suite: http://www.gtalbot.org/BrowserBugsSection/css21testsuite/ CSS 2.1 Test suite RC6, March 23rd 2011: http://test.csswg.org/suites/css2.1/20110323/html4/toc.html CSS 2.1 test suite harness: http://test.csswg.org/harness/ Contributing to to CSS 2.1 test suite: http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Thursday, 21 February 2013 01:51:31 UTC