- From: Gérard Talbot <css21testsuite@gtalbot.org>
- Date: Fri, 21 Sep 2012 15:31:54 -0400
- To: "Arron Eicholz" <Arron.Eicholz@microsoft.com>
- Cc: "Public CSS test suite mailing list" <public-css-testsuite@w3.org>
Le Ven 21 septembre 2012 14:13, Arron Eicholz a écrit : > On Thursday, September 20, 2012 9:15 PM Gérard Talbot wrote: >> >> Many paged/printing tests from Microsoft have/use and reuse the >> expression >> >> "standard letter sized sheet of paper" > > I only found this text in 2 files, position-fixed-004 and 005. I have > updated the cases to not state that any longer and I think I have > reworked 005 to better work in any case. [RC6] http://test.csswg.org/suites/css2.1/20110323/html4/position-fixed-004.htm [nightly-unstable] http://test.csswg.org/suites/css2.1/nightly-unstable/html4/position-fixed-004.htm [src] http://test.csswg.org/source/approved/css2.1/src/positioning/position-fixed-004.xht I think I "rubber-stamped" position-fixed-004 too fast. The new version of that test still has some issues. 1- The test is supposed to print more than 1 page: this expected result was not explicit in old and is not stated in newer version. When I print preview the test in Opera 12.02, I get only 1 page (under Linux KDE 4.9.1; I may try again later under Windows). So, testers strictly and formally complying with directives would say Opera passes when this is not true. div#filler's height changed from 3000px to 400%. So the test should now be able to anticipate, predict and specify number of pages printed or paginated. From what I can see, 5 pages should be printed. 2- Is there a need for the test to specify the height of div#div1 and to give it a background-color? I'm just asking this because I do not think this is necessary for the test, inside the goal of the test itself. Personally, I would remove line 25: background: lime; line 26: height: 25px; > > Let me know if it makes sense. 005 may still need a little tweaking. [RC6] http://test.csswg.org/suites/css2.1/20110323/html4/position-fixed-005.htm [nightly-unstable] http://test.csswg.org/suites/css2.1/nightly-unstable/html4/position-fixed-005.htm [src] http://test.csswg.org/source/approved/css2.1/src/positioning/position-fixed-005.xht This one is very good. 3 nitpicks though: a) It's PREREQUISITE, not PREREQUSITE b) <p>Test passes if there is only one page and there is no red underlined text visible when paginated or printed.</p> can be compacted with <p>Test passes if only one page is printed or paginated and if there is no red.</p> c) <span>Test fails if this line of text is visible when the page is paginated or printed.</span> can be reformulated as <span>Test fails if this sentence is paginated or printed.</span> Gérard -- Contributions to the CSS 2.1 test suite: http://www.gtalbot.org/BrowserBugsSection/css21testsuite/ CSS 2.1 Test suite RC6, March 23rd 2011: http://test.csswg.org/suites/css2.1/20110323/html4/toc.html CSS 2.1 test suite harness: http://test.csswg.org/harness/ Contributing to to CSS 2.1 test suite: http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Friday, 21 September 2012 19:32:20 UTC