- From: Gérard Talbot <css21testsuite@gtalbot.org>
- Date: Sun, 14 Oct 2012 01:23:11 -0400
- To: "Zhang, Zhiqiang" <zhiqiang.zhang@intel.com>
- Cc: "public-css-testsuite@w3.org" <public-css-testsuite@w3.org>, "Christensen, Kenneth" <kenneth.christensen@intel.com>, "Zhang, Haili" <haili.zhang@intel.com>, "Yu, Ling L" <ling.l.yu@intel.com>, "Yang, Lei A" <lei.a.yang@intel.com>
Le Dim 14 octobre 2012 1:17, "Gérard Talbot" a écrit : > Le Sam 13 octobre 2012 5:09, Zhang, Zhiqiang a écrit : > >> Review is appreciated: >> https://test.csswg.org/shepherd/search/testcase/author/intel/status/submitted/ > > > http://test.csswg.org/source/contributors/intel/submitted/css3-background/background-size-032.html > > This test should be using a dramatically bigger font-size (say, font: > 5em/1 == 80px/1) and most probably the Ahem font should be used so that > content area would be fully under control in the test. > > One issue is that background-image are painted behind glyphs, so here > Ahem font would need to be transparent (with color: transparent), > otherwise ::first-letter would need to declare absolute or relative > positioning. > > Since the test is about ::first-letter, then a single word should be > used; a full paragraph of 2 sentences is not needed. It should be line 13: div::first-letter and not line 13: div:first-letter -------- " Since green-with-no-red is often used to indicate success, it's best to also avoid green unless using the presence of red to indicate failures. " http://wiki.csswg.org/test/format#design-requirements So the color usage in background-size-032 is not best. Gérard -- Contributions to the CSS 2.1 test suite: http://www.gtalbot.org/BrowserBugsSection/css21testsuite/ CSS 2.1 Test suite RC6, March 23rd 2011: http://test.csswg.org/suites/css2.1/20110323/html4/toc.html CSS 2.1 test suite harness: http://test.csswg.org/harness/ Contributing to to CSS 2.1 test suite: http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Sunday, 14 October 2012 05:23:40 UTC