- From: Gérard Talbot <css21testsuite@gtalbot.org>
- Date: Tue, 20 Nov 2012 21:58:25 -0500
- To: "Zhang, Zhiqiang" <zhiqiang.zhang@intel.com>
- Cc: "Public CSS testsuite mailing list@w3.org" <public-css-testsuite@w3.org>, "Santos, Thiago" <thiago.santos@intel.com>, "Zhang, Haili" <haili.zhang@intel.com>, "Yu, Ling L" <ling.l.yu@intel.com>, "Yang, Lei A" <lei.a.yang@intel.com>
Le Mar 20 novembre 2012 20:47, Zhang, Zhiqiang a écrit : >> -----Original Message----- >> From: "Gérard Talbot" [mailto:css21testsuite@gtalbot.org] >> Sent: Friday, November 16, 2012 12:02 PM >> To: Zhang, Zhiqiang >> Cc: Public CSS testsuite mailing list@w3.org; Santos, Thiago; Zhang, >> Haili; Yu, >> Ling L; Yang, Lei A >> Subject: background-size-[025-029]: available, improved replacements >> > > Gérard, > > Thank you very much. > > http://hg.csswg.org/test/rev/6586e1a5824c > > Based on your review tests, I updated background-025, 028, 029, 030 and > 031; and added your reftest to background-size-026, so it needs approval > again. > Done. http://test.csswg.org/shepherd/testcase/background-size-026/#comment-920ffdd4237f >> >> >> >> http://test.csswg.org/source/contributors/intel/submitted/css3- >> background/background-size-027.html >> >> >> >> This test is more difficult than it may seem. >> >> >> >> background-repeat: repeat round; >> >> background-size: 60px auto; >> >> height: 180px; >> >> width: 180px; >> >> >> >> >> [snipped] >> >> >> Proposed replacement >> -------------------- >> >> http://www.gtalbot.org/BrowserBugsSection/review/background-size-027- >> review.html >> > > For background-size-027, as the test says "the width of the background > image is 52px" and won't be rounded to 60p, so I changed background > width to 156px from 180px in order to easily create a reftest (by > copying background-size-029-ref.xht and changing img width to 52px). And > I have to use "rectangles" instead of " squares". Please review it > again, thanks. Hmm... This is something tests should be trying to avoid (as a general rule): creating irregular shapes like a 60px tall by 52px wide rectangles. A 2:1 rectangle (say, 100px wide by 50px tall) is usually easy to recognize, but a 60 by 52 isn't easy to recognize... I guess we'll make an exception here since there is a reftest for this test. I have updated + uploaded http://www.gtalbot.org/BrowserBugsSection/review/background-size-027-review.html ------------ Zhiqiang, I have added http://www.gtalbot.org/BrowserBugsSection/review/reference/background-334-ref.xht as the reftest for your background-334 test and modified it accordingly. committed changeset 4782:222c51143ff6 Gérard -- Contributions to the CSS 2.1 test suite: http://www.gtalbot.org/BrowserBugsSection/css21testsuite/ CSS 2.1 Test suite RC6, March 23rd 2011: http://test.csswg.org/suites/css2.1/20110323/html4/toc.html CSS 2.1 test suite harness: http://test.csswg.org/harness/ Contributing to to CSS 2.1 test suite: http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Wednesday, 21 November 2012 02:59:17 UTC