- From: Zhang, Zhiqiang <zhiqiang.zhang@intel.com>
- Date: Wed, 21 Nov 2012 03:27:21 +0000
- To: "Gérard Talbot" <css21testsuite@gtalbot.org>
- CC: "Public CSS testsuite mailing list@w3.org" <public-css-testsuite@w3.org>, "Santos, Thiago" <thiago.santos@intel.com>, "Zhang, Haili" <haili.zhang@intel.com>, "Yu, Ling L" <ling.l.yu@intel.com>, "Yang, Lei A" <lei.a.yang@intel.com>
> -----Original Message----- > From: "Gérard Talbot" [mailto:css21testsuite@gtalbot.org] > Sent: Wednesday, November 21, 2012 10:58 AM > To: Zhang, Zhiqiang > Cc: Public CSS testsuite mailing list@w3.org; Santos, Thiago; Zhang, Haili; Yu, > Ling L; Yang, Lei A > Subject: Re: background-size-026, 027 need approval, review; reftest for > background-334 > > >> Proposed replacement > >> -------------------- > >> > >> http://www.gtalbot.org/BrowserBugsSection/review/background-size- > 027- > >> review.html > >> > > > > For background-size-027, as the test says "the width of the background > > image is 52px" and won't be rounded to 60p, so I changed background > > width to 156px from 180px in order to easily create a reftest (by > > copying background-size-029-ref.xht and changing img width to 52px). And > > I have to use "rectangles" instead of " squares". Please review it > > again, thanks. > > Hmm... This is something tests should be trying to avoid (as a general > rule): creating irregular shapes like a 60px tall by 52px wide > rectangles. A 2:1 rectangle (say, 100px wide by 50px tall) is usually > easy to recognize, but a 60 by 52 isn't easy to recognize... > I guess we'll make an exception here since there is a reftest for this > test. > > I have updated + uploaded > http://www.gtalbot.org/BrowserBugsSection/review/background-size-027- > review.html This test involves a 4th column blue-to-orange rectangles ( 3 60px tall by 24px wide), :) Opera 12.11 shows it. > > ------------ > > Zhiqiang, > > I have added > > http://www.gtalbot.org/BrowserBugsSection/review/reference/background > -334-ref.xht > > as the reftest for your background-334 test and modified it accordingly. > > committed changeset 4782:222c51143ff6 This is OK to me, thanks. > > Gérard > -- > Contributions to the CSS 2.1 test suite: > http://www.gtalbot.org/BrowserBugsSection/css21testsuite/ > > CSS 2.1 Test suite RC6, March 23rd 2011: > http://test.csswg.org/suites/css2.1/20110323/html4/toc.html > > CSS 2.1 test suite harness: > http://test.csswg.org/harness/ > > Contributing to to CSS 2.1 test suite: > http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors- > contributions-css21-testsuite.html
Received on Wednesday, 21 November 2012 03:27:52 UTC