background-size-026, 027 need approval, review

> -----Original Message-----
> From: "Gérard Talbot" [mailto:css21testsuite@gtalbot.org]
> Sent: Friday, November 16, 2012 12:02 PM
> To: Zhang, Zhiqiang
> Cc: Public CSS testsuite mailing list@w3.org; Santos, Thiago; Zhang, Haili; Yu,
> Ling L; Yang, Lei A
> Subject: background-size-[025-029]: available, improved replacements
> 

Gérard,

Thank you very much.

http://hg.csswg.org/test/rev/6586e1a5824c

Based on your review tests, I updated background-025, 028, 029, 030 and 031; and added your reftest to background-size-026, so it needs approval again.

> 
> 
> >> http://test.csswg.org/source/contributors/intel/submitted/css3-
> background/background-size-027.html
> >>
> >> This test is more difficult than it may seem.
> >>
> >>             background-repeat: repeat round;
> >>             background-size: 60px auto;
> >>             height: 180px;
> >>             width: 180px;
> >>
> 
> 
> [snipped]
> 
> 
> Proposed replacement
> --------------------
> 
> http://www.gtalbot.org/BrowserBugsSection/review/background-size-027-
> review.html
> 

For background-size-027, as the test says "the width of the background image is 52px" and won't be rounded to 60p, so I changed background width to 156px from 180px in order to easily create a reftest (by copying background-size-029-ref.xht and changing img width to 52px). And I have to use "rectangles" instead of " squares". Please review it again, thanks.

Received on Wednesday, 21 November 2012 01:48:19 UTC