- From: Gérard Talbot <css21testsuite@gtalbot.org>
- Date: Wed, 7 Sep 2011 15:12:46 -0700
- To: "Arron Eicholz" <arron.eicholz@microsoft.com>
- Cc: "Public CSS test suite mailing list" <public-css-testsuite@w3.org>
Arron, [RC6] http://test.csswg.org/suites/css2.1/20110323/html4/background-position-applies-to-004.htm [nightly-unstable] http://test.csswg.org/suites/css2.1/nightly-unstable/html4/background-position-applies-to-004.htm This testcase is supposed to test background-position applied to a table-row. Now, if the table-row has only 1 single cell, then how can such testcase be different from testing background-position being applied to a table-cell? My point is that to give a honest, good challenge to browsers, such testcase should make the table-row have 2 cells at minimum, and ideally the table should have at least 2 table-rows. All this is furthermore justified if other testcases demonstrate failures in some browsers. The testcase I have in mind here is http://the-dees.webs.com/iepp1/55-tr-bg-position.html ------------ [RC6] http://test.csswg.org/suites/css2.1/20110323/html4/vertical-align-117.htm [nightly-unstable] http://test.csswg.org/suites/css2.1/nightly-unstable/html4/vertical-align-117.htm [RC6] http://test.csswg.org/suites/css2.1/20110323/html4/vertical-align-117.htm [nightly-unstable] http://test.csswg.org/suites/css2.1/nightly-unstable/html4/vertical-align-118.htm When the set height of line box is the height of the font, then 'vertical-align: text-bottom' and 'vertical-align: bottom' are by definition (positioned) the same: the bottom of the line box is given by the bottommost point of glyphs (like descenders of p, q, y, j glyphs) of the font. Same thing with text-top and top. What I am trying to say here is that vertical-align values text-bottom, text-top, bottom and text-bottom should be tested where/when the line-height is greater than the font-size. So that top half-leading and bottom half-leading are not 0. So that such values give different rendered layout, different vertical values. So that vertical-align values text-bottom, text-top, bottom and text-bottom show and demonstrate differences. Otherwise, it is not a well targeted testcase, even for a basic testing of vertical-align values text-bottom, text-top, bottom and text-bottom. I suggest a line-height of 3em: that way, fractional pixel (for top half-leading and bottom half-leading) are avoided, top is predictable/predicted to be 1em further toward the top of text-top, bottom is predictable/predicted to be 1em further toward the bottom of text-bottom. regards, Gérard -- Contributions to the CSS 2.1 test suite: http://www.gtalbot.org/BrowserBugsSection/css21testsuite/ CSS 2.1 Test suite RC6, March 23rd 2011 http://test.csswg.org/suites/css2.1/20110323/html4/toc.html CSS 2.1 test suite harness: http://test.csswg.org/harness/
Received on Wednesday, 7 September 2011 22:13:20 UTC