Re: [CSS3]white-space-collapsing-discard-001.xht

On 02/16/2011 12:27 AM, taka oshiyama wrote:
> Hi
> Please find a new testcase
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/white-space-collapsing-discard-001.xht
>
> Please review it and give me comments if any. :-)

Here are my comments:

1. First comment is, this section is very unstable. :) You should probably
    focus on other sections first.

2. Second comment is, the test only tests spaces. It is not a very good
    test. It should test all white space characters that are supposed to
    collapse away, as well as characters that are similar to white space
    characters but are not supposed to collapse away. For example, ASCII
    space, tab, CR, LF must all collapse away, but U+3000 and Paragraph
    Separator must not collapse away, whether they are alone or in a
    sequence with other interesting characters. (For example, U+3000 should
    stay whether it is alone, part of a sequence of three U+3000 characters,
    or mixed with other white space characters.)

    I would suggest to make two tests: one that tests all kinds of sequences
    where the white space must go away (use a separate <div> for each test,
    so that you get a column of the same string many times); then make another
    test that makes sure non-collapsible characters do not disappear, in
    which case you will need to have test-reference pairs.

3. Third comment is, the blue text is distracting because it is saying
    something. Use something meaningless, such as a pattern of letters,
    instead. (This also means the test can be more compact.) If you want
    to explain the test, put the explanation in an HTML comment. The
    person evaluating the test should not be distracted by what the test
    means.

~fantasai

Received on Wednesday, 16 February 2011 21:49:34 UTC