- From: Gérard Talbot <css21testsuite@gtalbot.org>
- Date: Fri, 30 Jul 2010 12:13:24 -0700
- To: "public-css-testsuite@w3.org" <public-css-testsuite@w3.org>
- Cc: "Arron Eicholz" <Arron.Eicholz@microsoft.com>
Hello,
This is mostly for Arron.
Unless specified for "author: Ian Hickson", all individual comments
refer to Microsoft's testcases.
I did not find any big, huge errors.
Summary (mostly for Fantasai and Arron)
***************************************
- 4 Fractional pixel testcases: all identified with the searchable
string "Fractional pixel issue!". I have proposed alternative in each
cases.
- 2 erroneous meta assert: search for
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-applies-to-007.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-applies-to-007.htm
- many testcases resort to a #wrapper, sometimes abs. pos., sometimes
rel.pos., which, IMO, were unneeded
- many testcases declare div {height: 0} when it's not necessary and in
fact it would be preferred to not be declared so that the testcases
themselves can "speak" for themselves in terms of layout, positioning
- (involving many testcases) border-collapse: collapse should be removed
everywhere: this is not needed and may in fact interfere with the
testcases
- (involving a few testcases) whenever display: list-item is declared,
then the expected results should indicate that a list-marker bullet
should be present and where
- some testcases abuse of rel.pos. and abs. pos.: eg.
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-113.htm
Although technically correct, the testcase could be redone with less
declarations and less rules and be accurately targeted to meet/fulfill
the targeted properties of the test
- keyword "inherit" on percentage values have not been tested; this is a
gap in the test suite so far
e.g.: div {margin-left: 50%;} div > div {margin-left: inherit;}
- I have rejected Ian Hickson's 3 snowflakes character
http://test.csswg.org/suites/css2.1/20100727/html4/tables-101.htm
**************************
Section 8.1
===========
----------------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-backgrounds-001.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-border-padding-001.htm
Reviewed and approved.
----------------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-border-padding-002.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-border-padding-003.htm
Rejected both for the same reason:
vertical-align: text-bottom should be defined for the embedded image in
div#div3 otherwise the image/object "sits" on the baseline of div#div3
and increases the box content height
See, verify with
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/experiments-va-lineheight-02.html
----------------------
Section 8.3
===========
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c412-blockw-000.htm
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5501-imrgn-t-000.htm
The assert should say something like:
<meta name="assert" content="'margin-top' property has no effect on
non-replaced inline elements.">
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5501-mrgn-t-000.htm
Reviewed and approved.
{This testcase could be converted to use a bigger font size (like 20px
or 16px):
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/c5501-mrgn-t-000-gt.html
}
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5502-imrgn-r-000.htm
Reviewed and approved.
The testcase code could be reduced without weakening its
objective/intrinsic complexity and difficulty:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/c5502-imrgn-r-000-gt.html
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5502-imrgn-r-001.htm
Reviewed and approved.
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/c5502-imrgn-r-001-gt.html
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5502-imrgn-r-003.htm
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5502-imrgn-r-004.htm
Reviewed and approved.
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/c5502-imrgn-r-004-gt.html
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5502-mrgn-r-000.htm
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5502-mrgn-r-001.htm
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5502-mrgn-r-002.htm
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5502-mrgn-r-003.htm
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5503-imrgn-b-000.htm
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5503-mrgn-b-000.htm
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5504-imrgn-l-000.htm
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5504-imrgn-l-001.htm
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5504-imrgn-l-002.htm
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5504-imrgn-l-003.htm
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5504-imrgn-l-004.htm
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5504-imrgn-l-005.htm
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5504-imrgn-l-006.htm
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5504-mrgn-l-000.htm
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5504-mrgn-l-001.htm
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5504-mrgn-l-003.htm
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5505-mrgn-000.htm
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5505-mrgn-001.htm
Reviewed and approved.
----------------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/c5505-mrgn-003.htm
Reviewed and approved.
----------------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-001.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-002.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-003.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-004.htm
Reviewed and approved.
----------------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-005.htm
#div1's shrink-to-fit width is 3in which sets #div1's containing block
width (section 10.3.7) and forces margin-left and margin-right of #div2
to be 0 (section 10.3.3)
#div2's margin-top and margin-bottom are 0 as given by section 10.6.3
"If 'margin-top', or 'margin-bottom' are 'auto', their used value is 0."
I recommend to provide links to section 10.3.3 and 10.6.3 and to provide
more explicit explanations in the assert.
Proposed suggestion:
<link rel="help"
href="http://www.w3.org/TR/CSS21/box.html#margin-properties">
<meta name="flags" content="">
<meta name="assert" content="The 'margin' property with a value
of 'auto' correctly sizes the margin.">
to be replaced with
<link rel="help"
href="http://www.w3.org/TR/CSS21/box.html#margin-properties">
<link rel="help" title="10.3.3 Block-level, non-replaced
elements in normal flow"
href="http://www.w3.org/TR/CSS21/visudet.html#blockwidth">
<link rel="help" title="10.6 Calculating heights and margins,
3. block-level, non-replaced elements in normal flow"
href="http://www.w3.org/TR/CSS21/visudet.html#normal-block">
http://www.w3.org/TR/CSS21/visudet.html#blockwidth
http://www.w3.org/TR/CSS21/visudet.html#normal-block
<meta name="flags" content="">
<meta name="assert" content="The 'margin' property with a value
of 'auto' correctly sizes the margin. In normal flow,
'margin-top: auto' and 'margin-bottom: auto' for block-level,
non-replaced elements are resolved as 0. In normal flow,
'margin-left: auto' and 'margin-right: auto' for block-level,
non-replaced elements are resolved according to the constraint
equation for the width of containing block: 'margin-left' +
'border-left-width' + 'padding-left' + 'width' + 'padding-right'
+ 'border-right-width' + 'margin-right' = width of containing
block">
----------------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-006.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-007.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-008.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-009.htm
Reviewed and approved.
----------------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-applies-to-001.htm
Rejected
#wrapper
{
border: 10px solid blue;
position: absolute;
}
There is no need to create an abs. pos. #wrapper and to set
border-collapse: collapse on the table. It is also better not to set
those properties.
I suggest to use:
#table
{
border: blue solid 10px;
display: table;
}
E.g.:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-applies-to-001-gt.html
----------------------
On all following testcases:
Why an abs. pos. #wrapper? And why border-collapse: collapse?
http://test.csswg.org/suites/css2.1/20100727/html4/margin-applies-to-002.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-applies-to-003.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-applies-to-004.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-applies-to-005.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-applies-to-006.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-applies-to-007.htm
----------------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-applies-to-008.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-applies-to-009.htm
Reviewed and approved.
----------------------
Rejected
http://test.csswg.org/suites/css2.1/20100727/html4/margin-applies-to-010.htm
The expected results do not indicate if a bullet list-marker should be
rendered and where (on the left-hand side, inside or outside the orange
border). I think the bullet list-marker should be rendered on the
left-hand side, inside the orange border.
----------------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-applies-to-011.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-applies-to-012.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-applies-to-013.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-applies-to-014.htm
Reviewed and approved.
----------------------
Rejected
http://test.csswg.org/suites/css2.1/20100727/html4/margin-applies-to-015.htm
Why border-collapse: collapse?
The test would be ideal if no element has a defined width set to 320px;
ideally, you want the test to speak for itself in terms of layout,
margin and width.
The table-caption is a box rendered outside the table box itself.
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-applies-to-015-gt.html
----------------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-004.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-005.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-006.htm
div
{
height: 0;
}
can be removed.
----------------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-007.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-008.htm
div div
{
height: 0;
}
can be removed
----------------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-016.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-017.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-018.htm
div
{
height: 0;
}
can be removed.
----------------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-019.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-020.htm
div div
{
height: 0;
}
can be removed
----------------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-028.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-029.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-030.htm
div
{
height: 0;
}
can be removed.
----------------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-031.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-032.htm
div div
{
height: 0;
}
can be removed
----------------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-040.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-041.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-042.htm
div
{
height: 0;
}
can be removed
----------------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-043.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-044.htm
Fractional pixel issue!
In Firefox 3.x:
3.54cm (height) = 133.8px rounded up to 134px
1cm (border; 37.8px) + 2.54cm (margin: 96px) = 133.8px rounded down to
133px, not 134px because 1cm (border; 37.8px) is rounded down to 37px,
not 38px.
So, 1cm is sometimes 37px, sometimes 38px in Firefox
border-width: 1cm is 37px, not 38px; rounding down occurs.
height (or margin): 1cm is 38px, not 37px; rounding up occurs.
I suggest to use factors of 0.635cm (24px):
0.635cm (24px), 1.27cm (48px), 1.905cm (72px), etc.
to avoid all this.
See
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-bottom-043-gt.html
----------------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-052.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-053.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-054.htm
div
{
height: 0;
}
can be removed
----------------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-055.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-056.htm
Fractional pixel issue!
border-width: 1mm is rounding down from 3.7795px to 3px
while height: 1mm is rounded up from 3.7795px to 4px
Proposed replacement:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-bottom-055-gt.html
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-064.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-065.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-066.htm
div
{
height: 0;
}
can be removed
----------------
===============
From
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-065.htm
to
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-111.htm
inclusively have not been reviewed
===============
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-112.htm
Reviewed and approved.
---------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-112.htm
div
{
height: 0;
}
can be removed
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-applies-to-001.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-applies-to-002.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-applies-to-003.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-applies-to-004.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-applies-to-005.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-applies-to-006.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-applies-to-007.htm
Rejected.
#wrapper unneeded; border-collapse: collapse; unnecessary
Proposed alternatives:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-bottom-applies-to-001-gt.html
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-bottom-applies-to-002-gt.html
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-bottom-applies-to-003-gt.html
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-bottom-applies-to-004-gt.html
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-bottom-applies-to-005-gt.html
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-bottom-applies-to-006-gt.html
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-bottom-applies-to-007-gt.html
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-applies-to-008.htm
Margin-bottom can apply to inline elements but it actually has no
effect. And it is only because it has no effect that the testcase can be
passed.
"vertical margins will not have any effect on non-replaced inline
elements."
"'margin-top', 'margin-bottom'
These properties have no effect on non-replaced inline elements."
http://www.w3.org/TR/CSS21/box.html#margin-properties
The assert text should state this.
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-applies-to-009.htm
Reviewed and approved.
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-applies-to-010.htm
Rejected.
Proposed alternative:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-bottom-applies-to-010-gt.html
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-applies-to-011.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-applies-to-012.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-applies-to-013.htm
Reviewed and approved.
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-applies-to-014.htm
border-collapse: collapse is unneeded in that testcase.
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-bottom-applies-to-015.htm
#wrapper and border-collapse: collapse; unneeded for that testcase
Proposed alternative:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-bottom-applies-to-015-gt.html
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-inline-001.htm
Proposed alternative/replacement:
div
{
background: red;
font-family: ahem;
line-height: 1;
width: 4em;
}
span
{
color: green;
margin: 2em 0;
}
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-inline-002.htm
Reviewed and approved.
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-001.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-004.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-005.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-006.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-007.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-008.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-016.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-017.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-018.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-019.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-020.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-028.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-029.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-030.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-031.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-032.htm
Reviewed and approved.
Note that div {width: 0;} in all those tests was not required.
----------------
===============
From
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-040.htm
to
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-102.htm
inclusively have not been reviewed
===============
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-103.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-104.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-109.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-110.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-111.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-112.htm
Reviewed and approved.
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-113.htm
To test inherit keyword, I'm sure it would have been amply sufficient to
use 3 <div>s and this, without rel. pos. and without abs. pos.
Nevertheless, the testcase actually tests what it's supposed to test.
So,
Reviewed and approved.
Inherit keyword on a percentage value has not been tested.
Although rarely seen, this is missing in the test suite.
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-applies-to-001.htm
border-collapse: collapse and #wrapper unneeded
Proposed replacement:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-left-applies-to-001-gt.html
----------------
From
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-applies-to-002.htm
to
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-applies-to-007.htm
inclusively
Remove #wrapper, remove <div id="wrapper"> node, remove border-collapse:
collapse; then set
#table
{
border-left: 10px solid blue;
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-applies-to-007.htm
<meta name="assert" content="The 'margin-left' property applies to
elements with a display of table-cell.">
to change to
<meta name="assert" content="The 'margin-left' property does not apply
to elements with a display of table-cell.">
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-applies-to-008.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-applies-to-009.htm
Reviewed and approved.
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-applies-to-010.htm
Proposed adjustment:
Test passes if there is space between the blue and orange lines below.
There should be a bullet (filled disc) on the right-hand side of the
orange line.
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-applies-to-011.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-applies-to-012.htm
Reviewed and approved.
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-applies-to-013.htm
and
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-applies-to-014.htm
and
http://test.csswg.org/suites/css2.1/20100727/html4/margin-left-applies-to-015.htm
border-collapse: collapse is not required, not necessary, not needed.
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-percentage-undefined-001.htm
Reviewed and approved.
----------------
===============
margin-right* have not been reviewed
From
http://test.csswg.org/suites/css2.1/20100727/html4/margin-right-004
to
http://test.csswg.org/suites/css2.1/20100727/html4/margin-right-applies-to-015
inclusively have not been reviewed
===============
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-shorthand-001.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-shorthand-002.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-shorthand-003.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-shorthand-004.htm
Reviewed and approved.
----------------
===============
From
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-004.htm
to
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-102.htm
inclusively have not been reviewed
===============
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-103.htm
and
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-104.htm
Fractional pixel issue!
border-top: 0.1in solid red; /* == 9.6px and is resolved as 9px, not
rounded up to 10px /*
margin-bottom: -0.6in; /* == -57.6px and is resolved as -58
Also declaring
div
{
height: 0;
}
is not needed, required by those 2 tests.
Proposed replacement:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-top-103-gt.html
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-top-104-gt.html
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-113.htm
Fractional pixel issue!
border-top: 0.1in solid red; /* == 9.6px and is resolved as 9px, not
rounded up to 10px /*
margin-bottom: -0.6in; /* == -57.6px and is resolved as -58
Also declaring
div
{
height: 0;
}
is not needed, required by the test.
Proposed replacement:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-top-113-gt.html
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-applies-to-001.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-applies-to-002.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-applies-to-003.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-applies-to-004.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-applies-to-005.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-applies-to-006.htm
#wrapper unneeded, border-collapse: collapse unnecessary
Proposed replacements:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-top-applies-to-001-gt.html
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-top-applies-to-002-gt.html
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-top-applies-to-003-gt.html
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-top-applies-to-004-gt.html
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-top-applies-to-005-gt.html
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-top-applies-to-006-gt.html
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-applies-to-007.htm
The meta assert is wrong:
<meta name="assert" content="The 'margin-top' property applies to
elements with a display of table-cell.">
Proposed replacement:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/margin-top-applies-to-007-gt.html
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-applies-to-008.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-applies-to-009.htm
Reviewed and approved.
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-applies-to-010.htm
The expected results should state that there should be a list-marker
bullet immediately below the orange line.
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-applies-to-011.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-applies-to-012.htm
Reviewed and approved.
----------------
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-applies-to-013.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-applies-to-014.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-top-applies-to-015.htm
For these 3 tests:
border-collapse: collapse is unneeded, unnecessary
----------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/table-margin-001.htm
http://test.csswg.org/suites/css2.1/20100727/html4/table-margin-002.htm
These 2 tests are more about overflow hidden and height than about
margins for applying to a table.
Reviewed and approved.
----------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/table-margin-003.htm
Although more about height...
Reviewed and approved.
----------------
Author: Ian Hickson
http://test.csswg.org/suites/css2.1/20100727/html4/tables-101.htm
The expected results should state that all 3 snowflakes should not be
touching adjacent green borders or should not be overlapping green
borders.
I think proper rendering of glyphs inside table-cells should be part of
the test
Class, id and function all share the same identifer name: "test". That
is definitely not best.
I do not see the need for a setTimeout for that test.
Rejected
----------------
--
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/
CSS 2.1 test suite (beta 2; July 27th 2010):
http://test.csswg.org/suites/css2.1/20100727/html4/toc.html
CSS 2.1 test suite contributors:
http://test.csswg.org/source/contributors/
Received on Friday, 30 July 2010 19:14:01 UTC