- From: Anne van Kesteren <annevk@opera.com>
- Date: Wed, 22 Apr 2009 13:39:18 +0200
- To: public-css-testsuite@w3.org
Here are my remaining comments: at-charset-001.htm at-charset-002.htm at-charset-003.htm at-charset-004.htm at-charset-005.htm at-charset-006.htm Remove PREREQUISITE. at-charset-039.htm Incorrect, see emails. at-rule-001.htm at-rule-006.htm at-rule-011.htm at-rule-012.htm The at-rule-red.css needs to specify !important. It would also be good if not everything turned green on passing, but just "Filler Text". numbers-units-015.htm This should be more exact. If we use Ahem we can know exactly what the x-height is and therefore how high all the three boxes have to be. numbers-units-020.htm numbers-units-021.htm The PREREQUISITE here is already part of the general testing guidelines and can therefore be dropped. Other than this and the general comments on the style and presentation the tests seem fine. I haven't actually made any changes to tests yet (e.g. adding <link rel=reviewer>) because it is unclear to me whether these are the real source files of the tests and whether everyone is clear on the course of action. So I'll stick with simply emailing this list. I hope the tests in subversion are identical to the ones presented on http://samples.msdn.microsoft.com/ietestcenter/css.htm by the way since I've used both interchangeably in my review. -- Anne van Kesteren http://annevankesteren.nl/
Received on Wednesday, 22 April 2009 11:39:59 UTC