- From: Eira Monstad <eiram@opera.com>
- Date: Fri, 18 Jul 2008 16:17:09 +0200
- To: fantasai <fantasai.lists@inkedblade.net>
- Cc: public-css-testsuite@w3.org
On Fri, 18 Jul 2008 15:57:26 +0200, fantasai <fantasai.lists@inkedblade.net> wrote: > Eira Monstad wrote: >> Cheers, >> I've been working on some bidi related tests for the 2.1 testsuite, as >> well as converting a few of Richard Ishida's tests for language >> dependent styling to match the testsuite template. The tests are ready >> for review at http://people.opera.com/eiram/test/css21/review/ > > http://people.opera.com/eiram/test/css21/review/bidi-text-align-002.xht > http://people.opera.com/eiram/test/css21/review/bidi-text-align-003.xht > http://people.opera.com/eiram/test/css21/review/bidi-text-align-004.xht > > s/centered/centered horizontally/ Fixed. > http://people.opera.com/eiram/test/css21/review/bidi-text-align-007.xht > > Probably want to use ems here rather than px for the width. Also > alignment > would be easier to see if there was a one-word line that didn't wrap. Fixed. > http://people.opera.com/eiram/test/css21/review/bidi-text-align-008.xht > http://people.opera.com/eiram/test/css21/review/bidi-text-align-009.xht > http://people.opera.com/eiram/test/css21/review/bidi-text-align-010.xht > > Again, ems instead of px. Add an explanation of what you mean by > justified, e.g. > should be justified: the text should line up with the box edges > on both the left and right sides. Fixed. > Text-align should be the primary (first) spec section for all these > tests. Fixed. > I'll note that the last two tests don't seem to have much to do with bidi > (other than testing rtl scripts). That is true, if you by bidi mean "explicit bidi controls". The bidi algorithm is triggered by inherent RTL text too, though. But all these tests are really testing text-align in a bidi context rather than the other way around. -- Eira Monstad CoreQA Furthermore, it is my opinion that BTS2 must be destroyed
Received on Friday, 18 July 2008 14:19:00 UTC