- From: fantasai <fantasai.lists@inkedblade.net>
- Date: Thu, 02 Aug 2007 20:54:07 -0400
- To: Ray Kiddy <ray@ganymede.org>
- CC: public-css-testsuite@w3.org
Ray Kiddy wrote:
>
>
> Since it is my first one of these, I thought I would submit just one
> test, and it is a very simple one. I think I have got this right. Let me
> know if I am mistaken.
>
> % cat t040107-inv-sel-00-a.htm
> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN">
> <html>
> <head>
> <title>CSS 2.1 Test Suite: Ignoring Invalid Selectors</title>
> <link rel="help"
> href="http://www.w3.org/TR/CSS21/syndata.html#rule-sets">
> <style type="text/css">
> h3 { color: green }
> h1, h2 {color: green }
> h3, h4 & h5 {color: red }
> h6 {color: green }
> </style>
> </head>
> <body>
> <h6>This should be green.</h6>
> <h3>This should be green.</h3>
> <h1>This should be green.</h1>
> </body>
> </html>
Hello,
The test looks correct as it stands, however I recommend the following
changes:
1. Make the title more specific, e.g. add "(Invalid Combinator)"
to the title.
2. Add a <link rel="author"> as described here:
http://csswg.inkedblade.net/test/css2.1/format#credits
3. Add spec links as described here:
http://csswg.inkedblade.net/test/css2.1/format#specification-links
4. Test that h4 and h5 are also not red.
You might also want to switch to using <div>/<span> with a class instead
of the hN elements.
Note that only the XHTML 1.1 version is necessary: the other formats are
automatically generated from the XHTML 1.1 source.
~fantasai
Received on Friday, 3 August 2007 00:54:19 UTC