Re: [csswg-drafts] [cssom-view] Rename Element.isVisible to Element.isHidden? (#7317)

The CSS Working Group just discussed `[cssom-view] Rename Element.isVisible to Element.isHidden?`, and agreed to the following:

* `RESOLVED: Rename isVisible to isHidden and flipping default value`

<details><summary>The full IRC log of that discussion</summary>
&lt;dael> Topic: [cssom-view] Rename Element.isVisible to Element.isHidden?<br>
&lt;dael> github: https://github.com/w3c/csswg-drafts/issues/7317<br>
&lt;dael> joeyarhar: prop is to rename :isvisible to :isHidden<br>
&lt;fantasai> s/:isvisible/.isVisible/<br>
&lt;dael> joeyarhar: Got some feedback that isVisible is more about if it's painted but this is about DOM and style so we thought isHidden would make more sense<br>
&lt;dael> joeyarhar: That's pretty much it<br>
&lt;TabAtkins> I'm fine with the name either way, both seem reasonable to me.<br>
&lt;fantasai> s/:isHidden/.isHidden/<br>
&lt;dael> joeyarhar: The return value would be flipped since visible and hidden are opposite<br>
&lt;dael> Rossen_: Default for hidden is false?<br>
&lt;dael> joeyarhar: Yes, isHidden would return false b/c is not hidden<br>
&lt;dael> Rossen_: Seems straightforward proposal<br>
&lt;dael> Rossen_: Since we settled on isVisible previously, isHidden seems best choice. There is one proposal in the issue about naming isCssHidden but that goes against some of our naming schema<br>
&lt;dael> Rossen_: Additional thoughts? Suggestions?<br>
&lt;Rossen_> q<br>
&lt;dael> Rossen_: Obj to Rename isVisible to isHidden and flipping default value<br>
&lt;dael> RESOLVED: Rename isVisible to isHidden and flipping default value<br>
&lt;dael> fantasai: Should we ask authors for feedback?<br>
&lt;dael> Rossen_: We can. In what way?<br>
&lt;TabAtkins> Yeah, not that we should block the change one way or the other, just might be useful to vibe-check the direction of the name<br>
&lt;dael> fantasai: Ask authors in group or posters on twitter. We got no feedback from WG so seems like no opinion<br>
&lt;dael> vmpstr: Also worth pointing out isVisible is not used so fine to change<br>
&lt;dael> fantasai: Fine to change<br>
&lt;astearns> prior art (from linked issue) for 'visible' https://github.com/w3c/csswg-drafts/issues/6850#issuecomment-1011388347<br>
&lt;dael> chris: I think it's a better name. If something is hidden tells you truer information. If not hidden it depends on how big page is. Doesn't make incorrect promise.<br>
&lt;dael> Rossen_: Agree stronger promise<br>
&lt;fantasai> s/Fine to change/Fine to change, just nobody here seems to have expressed an opinion/<br>
&lt;dholbert> +1 to what Chris said<br>
&lt;dael> Rossen_: To fantasai point if we want someone to run a survey that would be great<br>
&lt;dael> jensimmons: I posted a tweet<br>
&lt;jensimmons> I posted this tweet: https://twitter.com/jensimmons/status/1532137408418004994<br>
&lt;dael> jensimmons: A bit late to hear from my usual audience but maybe over next day or so. We can decide now and reverse later<br>
&lt;chrishtr> I recommend making a decision now and we can update it if we hear other evidence<br>
&lt;dael> Rossen_: There's a well articulated reason to change. If we hear anything to the opposite we can reverse.<br>
&lt;fantasai> wfm<br>
&lt;dael> Rossen_: Thank you<br>
</details>


-- 
GitHub Notification of comment by css-meeting-bot
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/7317#issuecomment-1144232411 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Wednesday, 1 June 2022 23:11:30 UTC