Re: [csswg-drafts] [cssom-view] Rename Element.isVisible to Element.isHidden? (#7317)

The CSS Working Group just discussed `[cssom-view] Rename Element.isVisible to Element.isHidden?`.

<details><summary>The full IRC log of that discussion</summary>
&lt;fantasai> Topic: [cssom-view] Rename Element.isVisible to Element.isHidden?<br>
&lt;fantasai> github: https://github.com/w3c/csswg-drafts/issues/7317<br>
&lt;fantasai> chrishtr: Bringing up naming of isVisible/isHidden<br>
&lt;fantasai> chrishtr: Last week we resolved to change to isHidden<br>
&lt;fantasai> chrishtr: but also spun up some Twitter polls<br>
&lt;fantasai> chrishtr: Tab's poll indicated isVisible got more votes<br>
&lt;fantasai> chrishtr: Jen's poll seemed inconclusive?<br>
&lt;jarhar> https://twitter.com/jensimmons/status/1532137408418004994<br>
&lt;vmpstr> https://twitter.com/tabatkins/status/1532138513704943617<br>
&lt;fantasai> chrishtr: Also original reasons for isVisible<br>
&lt;fantasai> chrishtr: basically, doesn't guarantee it's visible<br>
&lt;fantasai> chrishtr: There's some conflicts with isVisible idea from IntersectionObserver<br>
&lt;fantasai> chrishtr: And conflicts with element.hidden<br>
&lt;fantasai> chrishtr: So that's the rundown<br>
&lt;fantasai> chrishtr: There's data both ways, so maybe leave the way it is?<br>
&lt;emilio> q+<br>
&lt;emilio> fantasai: there's also a comment suggesting checkVisibility<br>
&lt;emilio> ... maybe that would be possible?<br>
&lt;emilio> fantasai: I think the mixups between isVisible/isHidden in the twitter poll make me think we need to do a bit better<br>
&lt;fantasai> fantasai: and in the issue<br>
&lt;Rossen_> ack fantasai<br>
&lt;Rossen_> ack emilio<br>
&lt;fantasai> emilio: Was going to say something along the same lines<br>
&lt;fantasai> emilio: make it less confusing<br>
&lt;fantasai> emilio: I'm not sure I'm satisfied with either isVisible or isHidden<br>
&lt;fantasai> emilio: checkVisibility sounds reasonable<br>
&lt;chrishtr> checkVisibility is fine with me too<br>
&lt;smfr> not a fan of “check”<br>
&lt;fantasai> fantasai: checkVisibility with args and defaulting to a set of argus would maybe be less confusing<br>
&lt;fantasai> fantasai: you're checking for these specific things, not for total visibility<br>
&lt;emilio> computeVisibility?<br>
&lt;fantasai> Rossen_: Maybe investigate longer? Is there any pressure for this?<br>
&lt;fantasai> chrishtr: We'd like to implement in Chromium, so hoping we can come to an agreement<br>
&lt;fantasai> Rossen_: We have a name for now<br>
&lt;fantasai> Rossen_: I would say let's continue working in the thread, bikeshedding on the call not so helpful unless something comes up that's obvious<br>
&lt;fantasai> Rossen_: and don't have anything better atm<br>
&lt;fantasai> Rossen_: sounds like you're going to start writing code, changing name should be fairly straightforward<br>
&lt;fantasai> chrishtr: Have code written, want to ship it<br>
&lt;Rossen_> q?<br>
&lt;fantasai> chrishtr: Don't want to ship something the group disagrees with<br>
&lt;fantasai> fantasai: It's not so much about group disagreeing, it's about getting something we're confident that authors will find usable<br>
&lt;fantasai> fantasai: and the current information we have indicates that we maybe don't have that yet<br>
&lt;fantasai> fantasai: so I think we should work on it a bit more, so that when we ship, it's something authors find natural and easy to use<br>
&lt;fantasai> Rossen_: Should we continue to discuss here or take it back to the issue?<br>
&lt;emilio> Rossen_: is there anything we can do here right now or should we continue discussing in the issue?<br>
&lt;fantasai> Rossen_: Suggest engaging on the issue<br>
&lt;fantasai> Rossen_: Let's collect ideas and organize them and take the winner<br>
</details>


-- 
GitHub Notification of comment by css-meeting-bot
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/7317#issuecomment-1150123208 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Wednesday, 8 June 2022 16:15:43 UTC