Re: [XBL] content element and locked

On Wed, 10 Jan 2007, Cyril Concolato wrote:
> 
> I noticed a bug in the example describing 'locked'.
> 
>  <div id="right">
>    <ui:listbox id="right" title="Available Items">
>     <content includes="ui|listitem" id="rightList"/>
>    </ui:listbox>
>   </div>
> 
> The id="right" is used twice. Which one is right? I think the 'div' 
> element should not have an id.
> 
> Then the script code uses:
> 
> this.shadowTree.getElementById('right').xblSetInsertionPoint( ... )
> 
> I think it should be:
> 
> this.shadowTree.getElementById('rightList').xblSetInsertionPoint( ... )
> 
> Same for 'left' and 'leftList'.

Fixed.


> Also, could you change the name 'xblSetInsertionPoint' ? It is really 
> confusing. It is definitely not 'set' since you can add multiple 
> children to a content element and the term "insertion point" is not used 
> in the spec. It should be something like addContentChild.

I've changed it to xblAssign() for now but I'm going to discuss this with 
Hyatt later today to see if we can come up with a better name.

-- 
Ian Hickson               U+1047E                )\._.,--....,'``.    fL
http://ln.hixie.ch/       U+263A                /,   _.. \   _\  ;`._ ,.
Things that are impossible just take longer.   `._.-(,_..'--(,_..'`-.;.'

Received on Thursday, 11 January 2007 00:21:36 UTC